X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 q=dns; s=default; b=Vh/S28L0LAnav+MjDYxjYCGPJXPkTMYU4m5dlA9iJWZ
	nLFydyuJY+Cm1nQAMj6fPU/8Q1pQTNSNVP8zlyBiRd/loK+pAMLoj06mcF17ggnB
	CDivq0R4R3Sh28C+fsy1KNQWWbMx68kA+jzUUSaLfRgu4hBTJQUpXF3ME4aqHZBg
	=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 s=default; bh=MthGbz6KlrD0Kd2DY+mK9Bb5Fik=; b=fQv0IYIF+9tXxcxBT
	5TlDN1qS+j4Jfs8d2wjXomZWS8vdRfci/Q+3cJOcn+5vWbXUkD/Q9T7yKU/uNNLo
	MaaxSrVURid+s0WsXOgM/iszDNRAs2b68dEjNmLSesy1PVHG/93NkUAIWvcIBOCp
	4SqBnBLTNCEihcKwcR8j/xRdy4=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1
Message-ID: <51D0A6FF.9080403@cwilson.fastmail.fm>
Date: Sun, 30 Jun 2013 17:45:35 -0400
From: Charles Wilson <cygwin AT cwilson DOT fastmail DOT fm>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: Failed assertion in path.cc (path_conv::check)
References: <51C40016 DOT 3000409 AT cwilson DOT fastmail DOT fm> <20130621082155 DOT GG1620 AT calimero DOT vinschen DOT de>
In-Reply-To: <20130621082155.GG1620@calimero.vinschen.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 6/21/2013 4:21 AM, Corinna Vinschen wrote:
> On Jun 21 03:26, Charles Wilson wrote:
>> The following statement:
>>
>> char * tmp_path =
>>     (char *) cygwin_create_path (CCP_POSIX_TO_WIN_A, newargz[0]);
>>
>> Results in this error popup (and a coredump), when newargz[0] is
>> NULL. Sure, it's a bug in my program to do that...but shouldn't it
>> be handled more gracefully?  Like...return a NULL, rather than
>> SIGABRT?
>
> I changed the underlying cygwin_conv_path to handle NULL gracefully
> by returning -1 and setting errno to EINVAL.  This results in a NULL
> return from cygwin_create_path.

Using the old (buggy) version of my program, this change to the 
cygwin1.dll DTRT and I don't see the coredump anymore.  Thanks.

'Course, I've fixed my program to not do that, but this was still a 
cygwin bug IMO so thanks for fixing it.

--
Chuck



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple