X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,UNPARSEABLE_RELAY
X-Spam-Check-By: sourceware.org
Message-ID: <5082E008.10105@t-online.de>
Date: Sat, 20 Oct 2012 19:31:52 +0200
From: Christian Franke <Christian DOT Franke AT t-online DOT de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120826 Firefox/15.0 SeaMonkey/2.12
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: w32api-headers-3.0b_svn5431-1: _WIN32 no longer set on Cygwin
References: <5082A321 DOT 1050601 AT t-online DOT de>	<5082CF13 DOT 8090701 AT users DOT sourceforge DOT net> <CAEwic4a+9XeGwqOxs3_hJA3vp=oAYGhwUpt4n6anj_TLG36o6Q AT mail DOT gmail DOT com>
In-Reply-To: <CAEwic4a+9XeGwqOxs3_hJA3vp=oAYGhwUpt4n6anj_TLG36o6Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

Kai Tietz wrote:
> 2012/10/20 JonY wrote:
>> On 10/20/2012 21:12, Christian Franke wrote:
>>> Just for Info:
>>>
>>> The new /usr/include/w32api/windef.h does no longer define _WIN32.
>>>
>>> This may require compile fixes for some sources which check only for
>>> _WIN32 and not for __CYGWIN__ after windows.h is included.
>>>
>>> Christian
>> I can't imagine why you'd include windows.h and then check for _WIN32
>> after the fact, but I still think mixing win32 calls and Cygwin calls is
>> a bad idea, except for a few special cases.
>>
>> Anyway, I'll leave it to Kai to decide if it should be done, as I'm not
>> sure if this request is proper.
> That we don't define _WIN32 - actual we do internally but don't show
> it to includer - is done by intention.  Actual Corinna and I decided
> that this behavior is for cygwin the desired.

For the long term, it was IMO a good decision to change (fix) the old 
behavior.

For now, some (trivial) fixes to existing code may be required. I built 
the smartmontools-6.0-1 Cygwin package a few hours before the new 
headers were uploaded. Build from source package does no longer work 
with new headers (unfortunately the foreign CSMI include file requires 
_WIN32).

Christian


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple