X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-3.2 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD,TW_FN,TW_HF,TW_RW,TW_WX
X-Spam-Check-By: sourceware.org
Message-ID: <50534E66.2000108@lysator.liu.se>
Date: Fri, 14 Sep 2012 17:33:58 +0200
From: Peter Rosin <peda AT lysator DOT liu DOT se>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: cygwin AT cygwin DOT com, jari DOT aalto AT cante DOT net
Subject: Re: ATTENTION JARI AALTO Re: quilt: permission denied problems with helper scripts
References: <50530F64 DOT 8000009 AT lysator DOT liu DOT se> <20120914141609 DOT GB18998 AT ednor DOT casa DOT cgf DOT cx>
In-Reply-To: <20120914141609.GB18998@ednor.casa.cgf.cx>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

[I already had Jari on bcc, given the track record, but I
managed not to scream :-)  He's on bcc this time too]

On 2012-09-14 16:16, Christopher Faylor wrote:
> On Fri, Sep 14, 2012 at 01:05:08PM +0200, Peter Rosin wrote:
>> Hi!
>>
>> When working on some newlib patches, ran into this:
>>
>> peda AT pulkan ~/newlib/src/newlib
>> $ quilt refresh
>> /usr/share/quilt/refresh: line 253: /usr/share/quilt/scripts/remove-trailing-ws: Permission denied
>> Patch patches/wordexp-avoid-strdup.patch is unchanged
>>
>> peda AT pulkan ~/newlib/src/newlib
>> $ ls -lG /usr/share/quilt/scripts
>> total 68
>> -rwxr-xr-x 1 peda  6219 May 24  2011 backup-files
>> -rw-r--r-- 1 peda 13114 May 24  2011 dependency-graph
>> -rw-r-xr-x 1 peda  5910 May 24  2011 edmail
>> -rwxr-xr-x 1 peda  4642 May 24  2011 inspect
>> -rw-r--r-- 1 peda  3397 May 24  2011 parse-patch
>> -rw-r--r-- 1 peda 18389 May 24  2011 patchfns
>> -rw-r--r-- 1 peda  3491 May 24  2011 remove-trailing-ws
>>
>> All those files are scripts with shebangs, and I assume they
>> should all be chmod +x, and indeed that fixes the "quilt refresh"
>> problem (and a similar problem in "quilt mail" when it tries to
>> execute edmail).
>>
>> Please fix the packaging bug.

Oh, forgot to mention, "quilt mail" expects sensible-editor to
be a valid command (there are other places too, "quilt edit" and
"quilt header", if I grep for a bit), which seems to be some kind
of approach to do what $EDITOR normally does but perhaps using
alternatives instead?

But, Cygwin doesn't provide sensible-editor anywhere, so I had
to manually create a symlink for that to work. Here's my
workaround in case any quilt user needs it (which seems unlikely):
ln -s /usr/bin/vim /usr/local/bin/sensible-editor

A peek inside the quilt package reveals that sensible-editor is
a debianism and that upstream indeed uses $EDITOR. Jari, please
scratch the use-sensible-editor patch, or invent something that
provides sensible-editor and add that to Requires:

Also, upstream is at 0.60, so an update from 0.48 is overdue.

Cheers,
Peter


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple