X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_RX,TW_YG
X-Spam-Check-By: sourceware.org
Message-ID: <5033C360.1060007@cwilson.fastmail.fm>
Date: Tue, 21 Aug 2012 13:20:32 -0400
From: Charles Wilson <cygwin AT cwilson DOT fastmail DOT fm>
Reply-To: Charles Wilson <cygwin AT cwilson DOT fastmail DOT fm>
User-Agent: Mozilla/5.0 (Windows NT 5.2; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Oddity with cygport, debuginfo generation, and rxvt-unicode
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

While rebuilding rxvt-unicode, I saw the following error during 'cygport
install':

Preparing debuginfo source files:
realpath: unknown option -- p
Try `realpath --help' for more information.
	80 files
Preparing executables for UAC:


A little debugging showed that realpath is being invoked during
src_postinstall here:

line 978:do
                 # make sure that paths with '../' don't leave srcdir
                 case $(realpath -m ${dbgsrc}) in
                         ${dbgsrcdir}/*) ;;
                         *)  continue ;;
                 esac

                 srcf=${dbgsrc#${dbgsrcdir}/}

I see that this line is hit many times, but here is the relevant sequence:

...
realpath -m <iom_perl.xs
realpath -m -pe
realpath: unknown option -- p
Try `realpath --help' for more information.
realpath -m s/IOM_MODULE/urxvt/g,s/IOM_CLASS/urxvt/g
realpath -m |
realpath -m /usr/src/debug/rxvt-unicode-X-9.07-2/src/../libev/ev++.h
...

Although only the second of these lines triggers the error message, each
of the first four is problematic.

This looks like a bug in gcc/binutils to me; debug src paths shouldn't
include pipe line shell commands, should they?

In the meantime, I think a fix like this for cygport would be appropriate:

line 978:do
+          # avoid invoking realpath with redirection metacharacters
+          case "${dbgsrc}" in
+          *[\<\|\>]* ) continue;
+          esac

           # make sure that paths with '../' don't leave $dbgsrcdir
-          case $(realpath -m ${dbgsrc}) in
+          case $(realpath -m -- ${dbgsrc}) in
                   ${dbgsrcdir}/*) ;;
                   *)  continue ;;
           esac

           srcf=${dbgsrc#${dbgsrcdir}/}

...although I'm not sure if this might cause a problem if a filename
actually contains a shell redirection metacharacter (and the originating
project is always careful to appropriate quote that filename).

--
Chuck

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple