X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Message-ID: <4F6B632F.4040803@redhat.com>
Date: Thu, 22 Mar 2012 11:36:47 -0600
From: Eric Blake <eblake AT redhat DOT com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: GetDriveType on gnulib
References: <4F6B5E3F DOT 8020808 AT gmail DOT com>
In-Reply-To: <4F6B5E3F.8020808@gmail.com>
OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig138218E9E84F555EF3BE6AE2"
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

--------------enig138218E9E84F555EF3BE6AE2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 03/22/2012 11:15 AM, marco atzeri wrote:
> Hi Eric Blake,
>=20
> this portion of your gnulib code
>=20
> ----------------------------------------------
> #ifdef __CYGWIN__
> #include <windows.h>
> #define ME_REMOTE me_remote
> /* All cygwin mount points include `:' or start with `//'; so it
>    requires a native Windows call to determine remote disks.  */

Hmm; cygwin has had some improvements since I first wrote this - not the
least of which is that we redid mounting as part of the transition from
1.5.x to 1.7.x; maybe the real solution is to determine if cygwin now
provides indications of a remote mount point that the code is looking
for without having to drop to native function calls, and kill the
<windows.h> include in that case.  It's okay if that still requires the
use of a cygwin-specific function (that is, use of cygwin_internal would
be okay) if that's what it takes.  It may be a few days before I have
time to properly look at fixing this in gnulib, though.

--=20
Eric Blake   eblake AT redhat DOT com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enig138218E9E84F555EF3BE6AE2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJPa2MvAAoJEKeha0olJ0NqT4UIAJO0clayBofOQU/ACh7DVXBf
T7ns8sOHT6we/9vLFkm02bu4z7ax53gphBZEAw1nkJou1HLmuPZjkReiqKFu1ApS
Tl9cQI7lyLEdlzPv1CQ906ngxzrCvk+b9fu16otXxVrRvShavPaEqAPtcaN9/ci0
a655dR+BWrwYzCjKIUGMlLnQS+TYAjfm2oodGmuxr6nkIi06dCIcj0cSE7ZZ1ilU
VAiBMK/qoJb12+TfGEvvBtGNiL7np5ZEz7a7UuB2BvLFYFl1dLR/65qUVke0f7Xp
V68yoy0+ugaCfY76cP/ZOKXpIPV+T6DqhooF/TqzDAC1FieX5ruTq3L7N0jT5Ik=
=iWEo
-----END PGP SIGNATURE-----

--------------enig138218E9E84F555EF3BE6AE2--