X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Tue, 28 Feb 2012 11:24:26 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: 'more' segment faults with latest cygwin1.dll (1.7.11)
Message-ID: <20120228102426.GF23052@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <CAK-n8j4+JwjgjYwWOkR9Y9zMd1xzKDwd9F7w55aMG23CSRf9Kw AT mail DOT gmail DOT com> <20120227195959 DOT GC7534 AT calimero DOT vinschen DOT de> <1330384952 DOT 6720 DOT 20 DOT camel AT YAAKOV04> <20120228081859 DOT GA23052 AT calimero DOT vinschen DOT de> <1330422189 DOT 404 DOT 18 DOT camel AT YAAKOV04>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1330422189.404.18.camel@YAAKOV04>
User-Agent: Mutt/1.5.21 (2010-09-15)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Feb 28 03:43, Yaakov (Cygwin/X) wrote:
> On Tue, 2012-02-28 at 09:18 +0100, Corinna Vinschen wrote:
> > It's a bug in more, afaics.  In case of pressing 'n', the search function
> > is called with a NULL buf argument.  However, the function calls
> > strlen(buf) without checking buf for NULL.  The indentation at this
> > point in the file looks like this  `if (strlen(buf) > 0) {' has been
> > added as a kind of patch.
> 
> Yes, I had to patch more(1) to use regcomp/regexec instead of
> re_comp/re_exec, which we don't have on Cygwin.  With your clarification
> I should be able to fix it easily.

Just an idea, instead of working around them, why not just add them
to the lib?  You could copy the FreeBSD implementation which just
implements them in terms of the regcomp/regexec API:

http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/src/lib/libcompat/4.3/re_comp.c?rev=1.1;content-type=text%2Fplain


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple