X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Tue, 28 Feb 2012 09:18:59 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: 'more' segment faults with latest cygwin1.dll (1.7.11)
Message-ID: <20120228081859.GA23052@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <CAK-n8j4+JwjgjYwWOkR9Y9zMd1xzKDwd9F7w55aMG23CSRf9Kw AT mail DOT gmail DOT com> <20120227195959 DOT GC7534 AT calimero DOT vinschen DOT de> <1330384952 DOT 6720 DOT 20 DOT camel AT YAAKOV04>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1330384952.6720.20.camel@YAAKOV04>
User-Agent: Mutt/1.5.21 (2010-09-15)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Feb 27 17:22, Yaakov (Cygwin/X) wrote:
> On Mon, 2012-02-27 at 20:59 +0100, Corinna Vinschen wrote:
> > I can reproduce it as well, but the crash occurs in the application,
> > not in Cygwin.  Yaakov, this is from the util-linux package, can you
> > please have a look what happens there?
> 
> Yes, it's already on my todo list.

It's a bug in more, afaics.  In case of pressing 'n', the search function
is called with a NULL buf argument.  However, the function calls
strlen(buf) without checking buf for NULL.  The indentation at this
point in the file looks like this  `if (strlen(buf) > 0) {' has been
added as a kind of patch.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple