X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Message-ID: <4F4639FE.9040204@redhat.com>
Date: Thu, 23 Feb 2012 06:07:10 -0700
From: Eric Blake <eblake AT redhat DOT com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: gitk fix for set uicolor SystemButtonFace
References: <70952A932255A2489522275A628B97C31288F9F2 AT xmb-sjc-233 DOT amer DOT cisco DOT com> <CA+sc5mm9koy22F6CimBPd5LvUs5EqT0gNHj=nVD80fpNHtG4Hg AT mail DOT gmail DOT com>
In-Reply-To: <CA+sc5mm9koy22F6CimBPd5LvUs5EqT0gNHj=nVD80fpNHtG4Hg@mail.gmail.com>
OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig89935279883101F74A5B675E"
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

--------------enig89935279883101F74A5B675E
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 02/23/2012 05:53 AM, Earnie Boyd wrote:
> On Wed, Feb 22, 2012 at 4:54 PM, Matt Seitz (matseitz) wrote:
>> "Eric Blake (cygwin)" wrote:
>>>
>>> This release should cater to the fact that tcl is now X-based.  Before
>>> reporting any problems with gitk or git-gui, first check that you are
>>> running an X server.  Also, gitk will complain if your ~/.gitk has a
>>> line 'set uicolor SystemButtonFace'; there's nothing I can do about it
>>> at a packaging level, but you can remove the offending line to get
>> past it.
>>
>> Below is a diff of how I fixed the problem in my existing .gitk file.
>=20
> While this resolves an immediate issue you should determine the fix
> for platform determination in the upstream source so that the correct
> file is created in the first place.

The problem only occurs if you have a native-tcl run of gitk that
created ~/.gitk, then upgrade git to the X-tcl version, and reload that
~/.gitk.  If you only ever used gitk after installing the X-tcl version,
the upstream code is doing the correct thing.

But yes, an upstream patch that teaches gitk to be tolerant regardless
of which style ~/.gitk was previously created in would be appreciated.

--=20
Eric Blake   eblake AT redhat DOT com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enig89935279883101F74A5B675E
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJPRjn/AAoJEKeha0olJ0NqgaoH/A3Z4VBtXrHdd9fUSZD5JSTC
40nVu46jRRwt4P8GL38yT6IaD6Whrm6Nx//TD52vsBAD/QLFyYMAzIlI4O0FtJaw
NQY8aC5AhJuOiK/eedWBUdC6id4ne29ytcRml9E3lSbx16lz+p5n9/gA+yjBFaPJ
5+PjM2tOuraAWdkHdxGERK5lk0OANp3ZdLU4MXvBnhouaO+iN5V6+gtjF+llbcEs
+PoNkII811c/HmBAqbkVvWSpwZwZ2iZWfabQgGjcmLifpsFIMZm8yrVIG35vkHKL
iku00Lk0/VhYXUQxcn8mTU8pAtRUD0PsTVnkGvGUySSQ/MfMLS6UjGd+x7mIPts=
=byV2
-----END PGP SIGNATURE-----

--------------enig89935279883101F74A5B675E--