X-Recipient: archive-cygwin AT delorie DOT com X-Spam-Check-By: sourceware.org Date: Wed, 15 Feb 2012 16:38:51 +0100 From: Corinna Vinschen To: cygwin AT cygwin DOT com Subject: Re: STC for libapr1 failure Message-ID: <20120215153851.GQ25918@calimero.vinschen.de> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com References: <4F3A14A8 DOT 4090506 AT acm DOT org> <20120214140240 DOT GB25918 AT calimero DOT vinschen DOT de> <20120214144551 DOT GC25918 AT calimero DOT vinschen DOT de> <4F3AA0BB DOT 7000806 AT acm DOT org> <20120214182452 DOT GK25918 AT calimero DOT vinschen DOT de> <4F3AD58A DOT 9040106 AT acm DOT org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4F3AD58A.9040106@acm.org> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com On Feb 14 13:43, David Rothenberger wrote: > On 2/14/2012 10:24 AM, Corinna Vinschen wrote: > > On Feb 14 09:58, David Rothenberger wrote: > >> On 2/14/2012 6:45 AM, Corinna Vinschen wrote: > >>> On Feb 14 15:02, Corinna Vinschen wrote: > >>>> On Feb 14 00:00, David Rothenberger wrote: > >>>>> The libapr1 test cases are failing again for flock locks. This same > >>>>> test case failed with 1.7.9 with a fatal error[1], but that was > >>>>> corrected. The test is no longer encountering the fatal error, but > >>>>> it is producing the wrong result. > >>>> > >>>> Thanks for the testcase. I think I found the issue. An event handle > >>>> was closed in the wrong place, outside of the important mutex lock for > >>>> the lock object. I applied the patch to CVS. Your testcase now appears > >>>> to run fine for me. Can you try your entire testsuite again and see > >>>> if there's another failure lurking? > >>> > >>> I uploaded a snapshot for testing. > >> > >> Thanks. The snapshot fixes the flock test case, but now the fcntl test > >> case is failing. > > > > *Sob*. How so? Does it hang or does it allow multiple concurrent > > exclusive locks as the flock case? > > Sorry, I should have said. It hangs. > > >> I'll try to send an STC for that case, but I suspect the one from last > >> year will have the problem. > > > > Please send it anyway. > > It's attached. If you run it with an argument (any argument), each child > will print its loop count and you can see what happens. If it doesn't > hang for you, try increasing MAX_ITER or CHILDREN at the top. Did I mention that I hate synchronization problems? Anyway, I think I found the problem. I applied a patch which fixes the problem for me and, surprise!, the flock test still runs fine, too. I've just uploaded a new snapshot. Please give it a try. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple