X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Thu, 9 Feb 2012 11:26:12 +0100
From: Corinna Vinschen <vinschen AT redhat DOT com>
To: cygwin AT cygwin DOT com, newlib AT sourceware DOT org
Subject: Re: <sys/sysmacros.h> is broken
Message-ID: <20120209102612.GE23481@calimero.vinschen.de>
Mail-Followup-To: cygwin AT cygwin DOT com, newlib AT sourceware DOT org
References: <4F3279AC DOT 2010705 AT redhat DOT com> <20120208140657 DOT GJ25129 AT calimero DOT vinschen DOT de> <4F32DB30 DOT 8080807 AT redhat DOT com> <3862C5643B15B6468269546753EB2A92064F5CDF AT BLTSXVS01 DOT govsolutions DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3862C5643B15B6468269546753EB2A92064F5CDF@BLTSXVS01.govsolutions.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Feb  8 19:41, Howland Craig D (Craig) wrote:
> Eric:
>      I suggest adding a brief comment explaining the need for the
> static.
>      (For the lists, we had a brief off-list discussion, where Eric
> quoted
> C99 section 6.2.2 paragraph 5 and section 6.7.4 paragraph 6.  Together
> they give the details needed for understanding.  In short, the compiler
> can
> choose not to in-line the function, but without the static it would emit
> an
> external function call--which can fail at link if that function does not
> exist.  With the static, it can still choose to not in-line, but is
> required
> to provide a local function call within that translation unit.  I
> apologize

Adding such a comment sounds like a good idea.  With this change the
patch s ok to go in, Eric.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple