X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Thu, 22 Dec 2011 16:31:32 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: 16 byte pthread stack alignments
Message-ID: <20111222153132.GH31936@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <Pine DOT CYG DOT 4 DOT 58 DOT 1112201743030 DOT 3964 AT PC1163-8460-XP DOT flightsafety DOT com> <20111221094211 DOT GH23547 AT calimero DOT vinschen DOT de> <4EF1F937 DOT 9040107 AT gmail DOT com> <20111221154104 DOT GB11841 AT calimero DOT vinschen DOT de> <Pine DOT CYG DOT 4 DOT 58 DOT 1112211020000 DOT 3076 AT PC1163-8460-XP DOT flightsafety DOT com> <Pine DOT CYG DOT 4 DOT 58 DOT 1112211218020 DOT 3076 AT PC1163-8460-XP DOT flightsafety DOT com> <Pine DOT CYG DOT 4 DOT 58 DOT 1112211523340 DOT 3076 AT PC1163-8460-XP DOT flightsafety DOT com> <20111222092738 DOT GB31936 AT calimero DOT vinschen DOT de> <Pine DOT CYG DOT 4 DOT 58 DOT 1112220917560 DOT 3076 AT PC1163-8460-XP DOT flightsafety DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Pine.CYG.4.58.1112220917560.3076@PC1163-8460-XP.flightsafety.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Dec 22 09:20, Brian Ford wrote:
> On Thu, 22 Dec 2011, Corinna Vinschen wrote:
> 
> > On Dec 21 15:25, Brian Ford wrote:
> > > On Wed, 21 Dec 2011, Brian Ford wrote:
> > >
> > > Thanks for the fix Christopher, but I must be using the wrong compiler or
> > > something.  Here's my next issue:
> > >
> > > src/winsup/cygwin/child_info.h:
> > > In static member function static cygheap_exec_info*
> > > cygheap_exec_info::alloc():
> > > src/winsup/cygwin/child_info.h:115:
> > > error: invalid use of member cygheap_exec_info::children in static member
> > > function
> > > src/winsup/cygwin/sigproc.cc:914:
> > > error: from this location
> >
> > Did you try to drop the -Werror from the command line, for testing sake?
> 
> No, because in this case it actually is an error, not one converted from a
> warning.  Am I missing something, or shouldn't the cygwin sources compile
> without this kind of difficulty?  Is this really just a difference between
> the Cygwin gcc-4 and the one you guys use to cross compile?

Should be basically the same compiler:

  i686-pc-cygwin-gcc (GCC) 4.5.3 20110428 (Fedora Cygwin 4.5.3-4)

The error message is kind of nonsense anyway.  The expression in question
is

  sizeof (cygheap_exec_info) + (nprocs * sizeof (children[0]))

so it's just a `sizeof', not an actual usage of the member.  Try this
for now:

Index: sigproc.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/sigproc.cc,v
retrieving revision 1.372
diff -u -p -r1.372 sigproc.cc
--- sigproc.cc	10 Dec 2011 01:33:56 -0000	1.372
+++ sigproc.cc	22 Dec 2011 15:30:58 -0000
@@ -911,7 +911,7 @@ cygheap_exec_info::alloc ()
 {
  return (cygheap_exec_info *) ccalloc_abort (HEAP_1_EXEC, 1,
 					     sizeof (cygheap_exec_info)
-					     + (nprocs * sizeof (children[0])));
+					     + (nprocs * sizeof (cchildren)));
 }
 
 void


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple