Date: Mon, 5 Dec 2011 00:02:10 -0500
From: Christopher Faylor <cgf-use-the-mailinglist-please AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: gnome-keyring bug in snapshots
Message-ID: <20111205050210.GA22950@ednor.casa.cgf.cx>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <CAGvSfew2TFPGwp=Kq_bkJ0891+vJiAueAd1H+K_SHNimMw0y1Q AT mail DOT gmail DOT com> <20111203184459 DOT GA21371 AT ednor DOT casa DOT cgf DOT cx> <20111203213047 DOT GA24925 AT ednor DOT casa DOT cgf DOT cx> <20111203230408 DOT GC12518 AT calimero DOT vinschen DOT de> <20111204192741 DOT GA21203 AT ednor DOT casa DOT cgf DOT cx> <1323050598 DOT 6872 DOT 5 DOT camel AT YAAKOV04>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1323050598.6872.5.camel@YAAKOV04>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com

On Sun, Dec 04, 2011 at 08:03:18PM -0600, Yaakov (Cygwin/X) wrote:
>On Sun, 2011-12-04 at 14:27 -0500, Christopher Faylor wrote:
>> The real problem seemed to be a change introduced after 1.7.9 which
>> subtly broke the handling of signals during I/O.  That should be fixed
>> in the latest snapshot but, like so much of what I've worked on in Cygwin
>> lately, it touched a fundamental part of the code.  I wish I hadn't had
>> to make this change just before 1.7.10 but, in theory, it should make
>> it possible for a signal handler to be caught in a thread - that's a first
>> for Cygwin and it's something I've been meaning to get to for a while.
>
>The 20111204 snapshot fixes gnome-keyring.  Thanks!

That's a relief.  I have to admit that this is one of the few times that
I fixed a problem without first understanding the root cause.  I saw
that there was something fishy going on but it didn't seem to relate to
the gnome-keyring problem.  But after several stabs at fixing the fishy
problem, the gnome-keyring problem vanished.

>> This isn't perfect though and I hope that doesn't mean that I've
>> introduced other corner case problems.
>
>I'll continue testing CVS HEAD and see what happens.  How much more
>churn are you planning before 1.7.10?

I think (unless Corinna disagrees) that the current snapshot should be
considered 1.7.10rc1.  I really don't want to perturb the source code
any more now unless it's absolutely necessary.  Even this current fix is
basically just a band-aid.  I hope to rework some of the signal handling
for 1.7.11 to make things a little less ugly.

cgf

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple