X-Recipient: archive-cygwin AT delorie DOT com X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org X-Yahoo-SMTP: jenXL62swBAWhMTL3wnej93oaS0ClBQOAKs8jbEbx_o- Date: Fri, 3 Jun 2011 21:13:59 -0400 From: Christopher Faylor To: cygwin AT cygwin DOT com Subject: Re: Mercurial not returning with 20110601 snapshot Message-ID: <20110604011359.GA30631@ednor.casa.cgf.cx> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com References: <20110602122725 DOT GA23446 AT ednor DOT casa DOT cgf DOT cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com On Thu, Jun 02, 2011 at 09:05:57AM -0400, Chris Sutcliffe wrote: >On 2 June 2011 08:27, Christopher Faylor wrote: >> On Thu, Jun 02, 2011 at 06:43:40AM -0400, Chris Sutcliffe wrote: >>>Testing the 20110601 snapshot I've run in to an issue where Mercurial >>>(specifically python) will not return to the command line when the >>>command completes: >>> >>>I'm guessing this is related to the recent changes to pipe handling? >> >> Like other guesses about this: not necessarily. > >Fair enough, I should know better than to assume. Or, maybe I should just listen to your guesses. You were right. I made a change to the pipe code to speed up select and forgot to detect EOF conditions. It was a pretty glaring oversight on my part. This follows on the heels of my completely screwing up non-blocking reads on pipes so my track record hasn't been great in this area. The problem was easy to duplicate: echo hello | ssh someplace cat There were also several other problems with tty/console handling. My attempt to merge some of the console and pty handling has proved to be pretty tricky to get right. The console problems were tickled by strace so they were harder than usual to track down. Anyway, thanks for noticing the problem. It should be fixed in the snapshot that is being generated now. http://cygwin.com/snapshots/ Only the snapshot > 2011-06-01 will have the fix. cgf -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple