X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=0.5 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,T_TO_NO_BRKTS_FREEMAIL,URIBL_BLACK
X-Spam-Check-By: sourceware.org
MIME-Version: 1.0
In-Reply-To: <20110420011057.GA453@ednor.casa.cgf.cx>
References: <4DAC23E3 DOT 2020005 AT lysator DOT liu DOT se>	<4DAC2D35 DOT 5070106 AT lysator DOT liu DOT se>	<4DAC4B6A DOT 50101 AT lysator DOT liu DOT se>	<20110418152441 DOT GA12913 AT ednor DOT casa DOT cgf DOT cx>	<20110418152801 DOT GA11182 AT ednor DOT casa DOT cgf DOT cx>	<4DAC8F96 DOT 3080808 AT lysator DOT liu DOT se>	<4DADFF3A DOT 1060006 AT lysator DOT liu DOT se>	<20110420011057 DOT GA453 AT ednor DOT casa DOT cgf DOT cx>
Date: Wed, 20 Apr 2011 15:16:44 +0200
Message-ID: <BANLkTin0+sf0h=KZY5qMP9qfnPZd0XhSCg@mail.gmail.com>
Subject: Re: Memory leak in select
From: Thomas Stalder <cygwinml AT gmail DOT com>
To: cygwin AT cygwin DOT com
Content-Type: multipart/mixed; boundary=bcaec51b1ba7a6045504a1596ff7
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

--bcaec51b1ba7a6045504a1596ff7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hello,

I just have a question, the same change would it not necessary for the
functions: serial_cleanup, mailslot_cleanup and socket_cleanup in
select.cc (like attached patch) ?

I don't know, it's just a question. The patch are not tested.

Regards,

Thomas

2011/4/20 Christopher Faylor
>>2011-04-19 =A0Peter Rosin =A0<peda AT lysator DOT liu DOT se>
>>
>> =A0 =A0 =A0 * select.cc (pipe_cleanup): Don't leak a select_pipe_info wh=
en a
>> =A0 =A0 =A0 thread turned out not to be needed.
>
> Makes sense. =A0I've checked this in (with a different ChangeLog).

--bcaec51b1ba7a6045504a1596ff7
Content-Type: application/octet-stream; name="select.patch"
Content-Disposition: attachment; filename="select.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_gmqa9s3e0

LS0tIHNlbGVjdC5jY19vcmkJMjAxMS0wNC0yMCAxNDo0MjowMy45NTMxMjUw
MDAgKzAyMDAKKysrIHNlbGVjdC5jYwkyMDExLTA0LTIwIDE0OjQ1OjU2Ljg5
MDYyNTAwMCArMDIwMApAQCAtMTE1MCwxMyArMTE1MCwxNSBAQAogc2VyaWFs
X2NsZWFudXAgKHNlbGVjdF9yZWNvcmQgKiwgc2VsZWN0X3N0dWZmICpzdHVm
ZikKIHsKICAgc2VsZWN0X3NlcmlhbF9pbmZvICpzaSA9IChzZWxlY3Rfc2Vy
aWFsX2luZm8gKikgc3R1ZmYtPmRldmljZV9zcGVjaWZpY19zZXJpYWw7Ci0g
IGlmIChzaSAmJiBzaS0+dGhyZWFkKQorICBpZiAoIXNpKQorICAgIHJldHVy
bjsKKyAgaWYgKHNpLT50aHJlYWQpCiAgICAgewogICAgICAgc2ktPnN0b3Bf
dGhyZWFkID0gdHJ1ZTsKICAgICAgIHNpLT50aHJlYWQtPmRldGFjaCAoKTsK
KyAgICB9CiAgICAgICBkZWxldGUgc2k7CiAgICAgICBzdHVmZi0+ZGV2aWNl
X3NwZWNpZmljX3NlcmlhbCA9IE5VTEw7Ci0gICAgfQogfQogCiBzZWxlY3Rf
cmVjb3JkICoKQEAgLTE0NjUsMTUgKzE0NjcsMTcgQEAKIHsKICAgc2VsZWN0
X3NvY2tldF9pbmZvICpzaSA9IChzZWxlY3Rfc29ja2V0X2luZm8gKikgc3R1
ZmYtPmRldmljZV9zcGVjaWZpY19zb2NrZXQ7CiAgIHNlbGVjdF9wcmludGYg
KCJzaSAlcCBzaS0+dGhyZWFkICVwIiwgc2ksIHNpID8gc2ktPnRocmVhZCA6
IE5VTEwpOwotICBpZiAoc2kgJiYgc2ktPnRocmVhZCkKKyAgaWYgKCFzaSkK
KyAgICByZXR1cm47CisgIGlmIChzaS0+dGhyZWFkKQogICAgIHsKICAgICAg
IFNldEV2ZW50IChzaS0+dzRbMF0pOwogICAgICAgLyogV2FpdCBmb3IgdGhy
ZWFkIHRvIGdvIGF3YXkgKi8KICAgICAgIHNpLT50aHJlYWQtPmRldGFjaCAo
KTsKICAgICAgIFJlc2V0RXZlbnQgKHNpLT53NFswXSk7CisgICAgfQogICAg
ICAgc3R1ZmYtPmRldmljZV9zcGVjaWZpY19zb2NrZXQgPSBOVUxMOwogICAg
ICAgZGVsZXRlIHNpOwotICAgIH0KICAgc2VsZWN0X3ByaW50ZiAoInJldHVy
bmluZyIpOwogfQogCkBAIC0xNzAzLDEzICsxNzA3LDE1IEBACiBtYWlsc2xv
dF9jbGVhbnVwIChzZWxlY3RfcmVjb3JkICosIHNlbGVjdF9zdHVmZiAqc3R1
ZmYpCiB7CiAgIHNlbGVjdF9tYWlsc2xvdF9pbmZvICptaSA9IChzZWxlY3Rf
bWFpbHNsb3RfaW5mbyAqKSBzdHVmZi0+ZGV2aWNlX3NwZWNpZmljX21haWxz
bG90OwotICBpZiAobWkgJiYgbWktPnRocmVhZCkKKyAgaWYgKCFtaSkKKyAg
ICByZXR1cm47CisgIGlmIChtaS0+dGhyZWFkKQogICAgIHsKICAgICAgIG1p
LT5zdG9wX3RocmVhZCA9IHRydWU7CiAgICAgICBtaS0+dGhyZWFkLT5kZXRh
Y2ggKCk7CisgICAgfQogICAgICAgZGVsZXRlIG1pOwogICAgICAgc3R1ZmYt
PmRldmljZV9zcGVjaWZpY19tYWlsc2xvdCA9IE5VTEw7Ci0gICAgfQogfQog
CiBzZWxlY3RfcmVjb3JkICoK


--bcaec51b1ba7a6045504a1596ff7
Content-Type: text/plain; charset=us-ascii

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
--bcaec51b1ba7a6045504a1596ff7--