X-Recipient: archive-cygwin AT delorie DOT com X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,MAY_BE_FORGED,RCVD_IN_DNSWL_NONE,TW_YG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Message-ID: <4D831DAE.8060503@xs4all.nl> Date: Fri, 18 Mar 2011 09:54:06 +0100 From: Erwin Waterlander User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: cygwin AT cygwin DOT com Subject: Re: ITP dos2unix 5.2.1-1 References: <4D7FE2A7 DOT 8080409 AT xs4all DOT nl> <4D7FE57A DOT 4020903 AT redhat DOT com> <4D806DCF DOT 5090803 AT xs4all DOT nl> <4D80C0B8 DOT 8090603 AT cwilson DOT fastmail DOT fm> <4D80CEB4 DOT 7090005 AT xs4all DOT nl> <20110316154913 DOT GA18995 AT ednor DOT casa DOT cgf DOT cx> <4D80DEAF DOT 6020307 AT xs4all DOT nl> <4D810FAF DOT 6040609 AT t-online DOT de> <20110316193249 DOT GA15365 AT ednor DOT casa DOT cgf DOT cx> <4D8117FD DOT 40507 AT cwilson DOT fastmail DOT fm> <20110316201821 DOT GA773 AT ednor DOT casa DOT cgf DOT cx> <4D812DBE DOT 1090607 AT cwilson DOT fastmail DOT fm> <4D81CED1 DOT 9050601 AT xs4all DOT nl> <4D820D62 DOT 4030403 AT cwilson DOT fastmail DOT fm> <4D821D89 DOT 5020105 AT xs4all DOT nl> <4D823D92 DOT 1000600 AT cwilson DOT fastmail DOT fm> <4D826761 DOT 5030302 AT xs4all DOT nl> <4D826A52 DOT 8090009 AT redhat DOT com> <4D8270BB DOT 9010608 AT cwilson DOT fastmail DOT fm> <4D83017B DOT 2070607 AT cwilson DOT fastmail DOT fm> In-Reply-To: <4D83017B.2070607@cwilson.fastmail.fm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Op 18-3-2011 7:53, Charles Wilson schreef: > On 3/17/2011 4:36 PM, Charles Wilson wrote: >> OK, everybody, time out for a minute. Rather than talk vapor, I'll >> develop the patches necessary. > Fair warning: I've developed this patch set, and made a cygport-based > package...but I have NOT TESTED the apps at all. More later, but it's > way past my bed time... > >> The first one, or first set (e.g. #2, above), I'll propose that >> "official" upstream dos2unix accept *for all platforms*. It will not >> change upstream's behavior in any way, except for offering some new options. > 01-avoid-hardlink-exist-error.patch > 02-cygwin-defines-win32-but-isnt.patch > 03-add--safe-option.patch > 04-add-follow-no-follow--infile-only.patch > 05-rationalize-logic-flow.patch > 06-add-ResolveSymbolicLink-function.patch > 07-support-follow-no-follow--outfile.patch > 08-use-canonicalize-file-name-glibc24-cygwin17.patch > > === 01-avoid-hardlink-exist-error.patch > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > === 02-cygwin-defines-win32-but-isnt.patch > dos2unix.c | 10 +++++----- > unix2dos.c | 10 +++++----- > 2 files changed, 10 insertions(+), 10 deletions(-) > > === 03-add--safe-option.patch > dos2unix.c | 3 +++ > unix2dos.c | 3 +++ > 2 files changed, 6 insertions(+) > > === 04-add-follow-no-follow--infile-only.patch > dos2unix.c | 25 ++++++++++++++++++++++--- > unix2dos.c | 25 ++++++++++++++++++++++--- > 2 files changed, 44 insertions(+), 6 deletions(-) > > === 05-rationalize-logic-flow.patch > dos2unix.c | 27 ++++++++++++++++----------- > unix2dos.c | 27 ++++++++++++++++----------- > 2 files changed, 32 insertions(+), 22 deletions(-) > > === 06-add-ResolveSymbolicLink-function.patch > dos2unix.c | 94 ++++++++++++++++++++++++++++++++++++++ > unix2dos.c | 94 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 188 insertions(+) > > === 07-support-follow-no-follow--outfile.patch > dos2unix.c | 72 +++++++++++++++++++++++++++++++++++++------ > unix2dos.c | 72 +++++++++++++++++++++++++++++++++++++------ > 2 files changed, 132 insertions(+), 12 deletions(-) > > === 08-use-canonicalize-file-name-glibc24-cygwin17.patch > dos2unix.c | 13 +++++++++++++ > unix2dos.c | 13 +++++++++++++ > 2 files changed, 26 insertions(+) > > Assuming they work (natch) I think these are suitable for upstream. > >> The second one (#1, above), I'll propose that Erwin use as part of his >> initial cygwin package offering. This one would be only a transitional >> measure, and would be slated to be dropped from a later cygwin package >> after a certain amount of time has passed. > === dos2unix-5.2.1-1.src.patch > dos2unix.c | 2 +- > unix2dos.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > Obviously, this one would eventually disappear, and would never go > "upstream". > > > Then, of course, there's the purely packaging related patch: > > === dos2unix-5.2.1-1.cygwin.patch > dos2unix.README | 95 ++++++++++++++++++++++++++++++++++++ > setup.hint | 7 ++++ > 2 files changed, 102 insertions(+) > >> With regards to the d2u/u2d aliases, for now I'd just modify the cygport >> script to create those as hardlinks, and not modify or patch the package >> source at all. > cygport script handles this. So... > > http://cygwin.cwilson.fastmail.fm/dos2unix-5.2.1-1-src.tar.bz2 > http://cygwin.cwilson.fastmail.fm/dos2unix-5.2.1-1.tar.bz2 > > ...but be warned...ZERO testing so far. > Hi Chuck, Thank you very much for your hard work! I will have a look at it and do some testing. Erwin -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple