X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Wed, 2 Feb 2011 11:17:10 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: err.h declarations not marked noreturn.
Message-ID: <20110202101710.GC32233@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <AANLkTimhvza1E0bj7EmBURK+Sc22R9x265sjLdVxeNAw AT mail DOT gmail DOT com> <201102011259 DOT 53193 DOT rusty AT rustcorp DOT com DOT au> <AANLkTimViNGmPH0q8h1gASOYiD1mYqowDRJTecAbx+1O AT mail DOT gmail DOT com> <201102020911 DOT 31282 DOT rusty AT rustcorp DOT com DOT au> <4D489B12 DOT 4080807 AT redhat DOT com> <20110202095851 DOT GA32233 AT calimero DOT vinschen DOT de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20110202095851.GA32233@calimero.vinschen.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Feb  2 10:58, Corinna Vinschen wrote:
> On Feb  1 16:45, Eric Blake wrote:
> > On 02/01/2011 03:41 PM, Rusty Russell wrote:
> > > OK, your /usr/include/err.h doesn't have the annotations to tell gcc that it
> > > doesn't return.
> > 
> > I'm a bit surprised that cygwin provides the BSD interface err() but
> > lacks the glibc interface error() from "error.h", even though both
> > interfaces are equally non-standard, and cygwin strives more for Linux
> > compatibility.  [...]
> 
> That's a clear case of 
> http://cygwin.com/acronyms/#SHTDI
> http://cygwin.com/acronyms/#PTC
> 
> > > Mine looks like so (Ubuntu):
> > > 
> > > 	extern void err (int __status, __const char *__format, ...)
> > > 	     __attribute__ ((__noreturn__, __format__ (__printf__, 2, 3)));
> > 
> > But it is indeed the case that the BSD interface err() always calls
> > exit() (see cygwin/libc/bsdlib.cc in the sources), and could therefore
> > be marked noreturn in the headers if someone were to provide a patch.
> 
> ...as long as we don't just copy the Linux headers for licensing
> reasons.

For now I added the noreturn attribute to the [v]err[x] functions.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple