X-Recipient: archive-cygwin AT delorie DOT com X-Spam-Check-By: sourceware.org Date: Wed, 18 Aug 2010 11:06:01 +0200 From: Corinna Vinschen To: cygwin AT cygwin DOT com Subject: Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff Message-ID: <20100818090601.GQ11340@calimero.vinschen.de> Mail-Followup-To: cygwin AT cygwin DOT com References: <20100812225838 DOT GB15724 AT ednor DOT casa DOT cgf DOT cx> <4C647D32 DOT 1090907 AT redhat DOT com> <20100817090816 DOT GB16404 AT calimero DOT vinschen DOT de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com On Aug 17 22:44, Pedro Izecksohn wrote: > --- Corinna Vinschen wrote: > > > > For this patch, given that it is just a bunch of rather obvious > > defines, I don't think we have to treat the patch as significant. > > I do not think that these macros are obvious. I think that I was > there when these macros were first implemented at 1987: I talked with > the programmer who was paid by the Correios to port everything from > the mainframe to the Apple II. I was a stenchy kid with his father, > that asked the employee what he was doing. When I asked about other > possibilities of endianness, the programmer answered about the PDP. > The programmer explained about BSD being a flavor of Unix. That talk > changed my life. > > > However, please don't use _BSD_SOURCE.  The newlib/Cygwin headers are > > not set up like the Linux headers and the big bunch of definitions from > > /usr/include/features.h are not available so far.  The _BSD_SOURCE > > define is not honored or set anywhere right now. > > > > What you can do is to use _POSIX_SOURCE.  So, if you're going to use > > #ifndef _POSIX_SOURCE instead, and if you're creating a ChangeLog entry > > in the correct ChangeLog entry format (see the ChangeLog file), then > > I guess we can check it in. > > Would you agree with: > > #if defined _BSD_SOURCE || ! defined _POSIX_SOURCE Ok. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple