X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=2.7 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DONT_USE_RAW_EMAIL_IN_BODY,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By: sourceware.org
MIME-Version: 1.0
In-Reply-To: <20100812095930.GX14202@calimero.vinschen.de>
References: <AANLkTinNXnksnBKU7EKC4mFsqR9P5uAFsgTn0WyJ1Z=j AT mail DOT gmail DOT com>	<20100812095930 DOT GX14202 AT calimero DOT vinschen DOT de>
Date: Thu, 12 Aug 2010 07:37:52 -0600
Message-ID: <AANLkTim0EAbuHF81OC0RX_qz2jMf_Sqhj0tNOCyQNV8c@mail.gmail.com>
Subject: Re: Postinstall script errors
From: Jeremy Ramer <jdramer AT gmail DOT com>
To: cygwin AT cygwin DOT com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Thu, Aug 12, 2010 at 3:59 AM, Corinna Vinschen
<corinna-cygwin AT cygwin DOT com> wrote:
> On Aug 11 09:18, Jeremy Ramer wrote:
>> I recently upgraded from cygwin 1.5 to 1.7. At the end of the install
>> there were errors with some of the postinstall scripts. =A0From the
>> setup.full.log:
>>
>> 2010/08/11 08:39:53 running: C:\cygwin\bin\bash.exe --norc --noprofile
>> /etc/postinstall/bash.sh
>> ln: creating symbolic link `/dev/stdin': File exists
>> 2010/08/11 08:39:54 abnormal exit: exit code=3D1
>> 2010/08/11 08:39:54 running: C:\cygwin\bin\bash.exe --norc --noprofile
>> /etc/postinstall/passwd-grp.sh
>> 2010/08/11 08:39:55 abnormal exit: exit code=3D1
>>
>>
>> I tried manually running the scripts with mixed results
>>
>> $ bash --norc --noprofile /etc/postinstall/bash.sh ; echo $?
>> 0
>>
>> $ bash --norc --noprofile /etc/postinstall/passwd-grp.sh ; echo $?
>> 1
>>
>> I tired manually running the commands inside passwd-grp.sh and they
>> all return 0. So I'm not sure what exactly is failing. =A0Is there
>> anything I should do to investigate?
>
> That's probably a fault in the postinstall scripts. =A0It would be nice if
> you could provide more details about what fails exactly in the script,
> or better, what in the script has a non-0 exit code. =A0That would help us
> lazy maintainers to fix the scripts faster.

The issue with the passwd-grp.sh script seems to be the last two lines.

[ "$created_passwd" =3D "yes" ] && /bin/chgrp --silent root /etc/passwd
[ "$created_group" =3D "yes"  ] && /bin/chgrp --silent root /etc/group

I verified that $created_passwd and $created_group were both no so
both conditionals will fail. But because the last conditional is the
last thing run, the script returns 1.  Adding an exit 0 to the script
fixes it, but I'm not sure if that accomplishes what you want from the
script.

Jeremy

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple