X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_FRT_SLUT,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Message-ID: <4BD6ED8A.4080403@redhat.com>
Date: Tue, 27 Apr 2010 07:58:34 -0600
From: Eric Blake <eblake AT redhat DOT com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b1 Thunderbird/3.0.4
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: Cygwin's GCC doesn't like this .sa_handler initialization for     some reason
References: <20100425113232 DOT GA11541 AT sbox>  <4BD5C311 DOT 2060708 AT redhat DOT com>  <4BD5E165 DOT 6070907 AT gmail DOT com> <20100427090516 DOT GA12365 AT calimero DOT vinschen DOT de>
In-Reply-To: <20100427090516.GA12365@calimero.vinschen.de>
Content-Type: multipart/signed; micalg=pgp-sha256;  protocol="application/pgp-signature";  boundary="------------enigBDDAB1EDB7ADCFDAFFEA6652"
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

--------------enigBDDAB1EDB7ADCFDAFFEA6652
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 04/27/2010 03:05 AM, Corinna Vinschen wrote:
> Like this?  We are already using analog definitions in the socket header
> files.

Yes, that looks right.

>=20
> Index: include/cygwin/signal.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvs/src/src/winsup/cygwin/include/cygwin/signal.h,v
> retrieving revision 1.18
> diff -u -p -r1.18 signal.h
> --- include/cygwin/signal.h	26 Feb 2010 05:43:50 -0000	1.18
> +++ include/cygwin/signal.h	27 Apr 2010 07:23:05 -0000
> @@ -194,14 +194,16 @@ typedef void (*_sig_func_ptr)(int);
>=20=20
>  struct sigaction
>  {
> -  __extension__ union
> +  union
>    {
>      _sig_func_ptr sa_handler;  		/* SIG_DFL, SIG_IGN, or pointer to a fu=
nction */
>      void  (*sa_sigaction) ( int, siginfo_t *, void * );
> -  };
> +  } __sighandler_or_action;
>    sigset_t sa_mask;
>    int sa_flags;
>  };
> +#define sa_handler	__sighandler_or_action.sa_handler
> +#define sa_sigaction	__sighandler_or_action.sa_sigaction

And while we're touching the file, we probably want to do similar
treatment for struct siginfo_t: si_tid, si_overrun, si_sigval, si_value,
si_status, si_utime, si_stime, and si_addr.

--=20
Eric Blake   eblake AT redhat DOT com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


--------------enigBDDAB1EDB7ADCFDAFFEA6652
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEbBAEBCAAGBQJL1u2PAAoJEKeha0olJ0Nq4o0H+OW0G8rrC7lKxyqadlN5icjh
I8OzOHLz8MpDkiNPROsQy821BjAOE5Qr9rbzCktg4d0ClC8ibg2OeGB4NTu2aohA
Lmq8TaGfg4YzzkjgYiQDFMv0WCQ3Gt4lNynaLqUuxXFvw2CLgQby1/EQSnTAFQvP
Il6fGF/xK90yC2dsuGCU+tk7BliRHJlgBQz69+04pYqT9wmQdF8pNrBeQLFiUcls
HSKSnlEqNAbVhmW79zVA8PVFkwZTpr51aJVqjne481Xxn41mQRRVTN3fyJPnHeRf
q/0rJRAbmA797U4D6XmsKL7K+cc6xZcaseg0EGTk2jxxMgmYv9YMOgRQbe+Nyg==
=MQMM
-----END PGP SIGNATURE-----

--------------enigBDDAB1EDB7ADCFDAFFEA6652--