X-Recipient: archive-cygwin AT delorie DOT com X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Message-ID: <4BC8A03F.2030701@redhat.com> Date: Fri, 16 Apr 2010 11:37:03 -0600 From: Eric Blake User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b1 Thunderbird/3.0.4 MIME-Version: 1.0 To: cygwin AT cygwin DOT com Subject: Re: scripting elevated privilege on Windows 7 References: <20100416163317 DOT GA27371 AT panix DOT com> In-Reply-To: <20100416163317.GA27371@panix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig3D8D176194DC6D82D743CC19" X-IsSubscribed: yes Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com --------------enig3D8D176194DC6D82D743CC19 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 04/16/2010 10:33 AM, DavidArnstein AT panix DOT com wrote: > Thank you Robert Pendell! I wrote this shell script. Any suggestions > for optimization? >=20 > #!/bin/bash > if [ $# -eq 1 ] > then > echo "Usage: elev program arg1 arg2 ..." > exit 1 > fi > prog=3D"$1" In assignment, there is no field splitting, so "" is redundant; this is equivalent: prog=3D$1 > shift > exec cygstart --action=3Drunas `which "$prog"` "$@" You are missing some quotes, and might as well use nicer quoting styles: exec cygstart --action=3Drunas "$(which "$prog") "$@" --=20 Eric Blake eblake AT redhat DOT com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enig3D8D176194DC6D82D743CC19 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJLyKA/AAoJEKeha0olJ0NqNjcIAJQTUbXXE56R0xTkf4Zg5MnN Eo7b9sNMpDeqWfSX2UzI79S4K9oW9/bqCeVgex/tmQCIt95l6Mfk0apz4kP/6JMu CkBWouvbuoqF7B0JidnIzccd9FVuIceiHIJtWm3WC0IwJN6DVuiyNn2iFcL29JdT 6QkP3OYX20bc9R1A4yFsmj6OmFezaeC3EnMLGzffW+oQByIKaHzL4wDLLMMTenCt n4WX/LE1+imvPeLuPCB3D+78pufPOfJTD/k7fL584b6LctlNBoO5WV3W81ip4OTl z5MkGw5zVTo/pPukme5Y3lVhVz+1Fy9rf+L7ZgjPcZlj14v5KqGFh9TuMEfy/Sw= =bpaR -----END PGP SIGNATURE----- --------------enig3D8D176194DC6D82D743CC19--