X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,TW_LR,TW_RW,TW_WX,TW_XR,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Date: Tue, 6 Apr 2010 15:54:36 -0500 (CDT)
From: Tim McDaniel <tmcd AT panix DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: 1.7 setup.exe overwrites softlink for home
In-Reply-To: <4BBB9D08.3090403@whack.org>
Message-ID: <Pine.NEB.4.64.1004061548490.3457@panix2.panix.com>
References: <1270563217 DOT 20907 DOT ezmlm AT cygwin DOT com> <4BBB9D08 DOT 3090403 AT whack DOT org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

Corinna Vinschen wrote:
> Peter Wohlers wrote:
>> Since upgrading to 1.7, I keep seeing weird problems with deletion
>> of my homedir symlink.
>>
>> Before running setup:
>> pwohlers AT h1n1 ~
>> $ ll /
>> [...]
>> lrwxrwxrwx   1 Domain Users     18 2010-04-04 14:31 home ->
>> /cygdrive/d/Users/
>> [...]
>> After running setup:
>> [...]
>> Setup seems to have deleted the softlink for /home
>
> Well... yes.  That's probably a bit unfortunate.  The current mechanism
> always creates a couple of directories if they don't already exist:
>
...
>   /home
...
> If the directory couldn't be created because a non-directory file
> uses the same name, it deletes that file and tries to create the
> directory again.  It's not perfect, but at least we know that the
> directories exist, afterwards.  We could add a mode which drops the
> aggressive creation strategy, but I only see that *could* make sense
> for home.

Um, so I suppose it's doing a test for symlinks specifically.  Why not
just test that /home is a directory via stat(), and if so, leave it
alone?  Perhaps it doesn't have stat() available and it would be extra
work to cobble it together in that environment?

-- 
Tim McDaniel, tmcd AT panix DOT com

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple