X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Wed, 10 Mar 2010 10:59:29 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Cygwin 1.7: Concurrency Issue with Shared State Initialization
Message-ID: <20100310095929.GY6505@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <B10B50309DC54D45A855FD66F56015F71D07D2ABBC AT DEWDFECCR03 DOT wdf DOT sap DOT corp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B10B50309DC54D45A855FD66F56015F71D07D2ABBC@DEWDFECCR03.wdf.sap.corp>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Mar 10 10:55, Schmidt, Oliver wrote:
> Hi Corrina,
> 
> Thanks for your involvement :-)
> 
> >> [...] a spinlock [...] With
> >> InterlockedCompareExchange() and Sleep() it should be quite simple to
> >> create one that's very efficient in the usual scenario.
> 
> > Does the below patch fix this for you?
> 
> I'll test the snapshot asap!
> 
> [...]
> +      LONG init = InterlockedCompareExchange (&installation_root_init, 1L, 0L);
> [...]
> +	  low_priority_sleep (0);
> [...]
> 
> I see we were thinking along the same lines ;-)

The final patch is from cgf.  It's probably more performant since it
drops the requirement for an additional spinlock.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple