X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Message-ID: <4B85E902.7040209@cwilson.fastmail.fm>
Date: Wed, 24 Feb 2010 22:05:38 -0500
From: Charles Wilson <cygwin AT cwilson DOT fastmail DOT fm>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: terminfo [Re: console enhancements: mouse events etc]
References: <4B266F9B DOT 6070204 AT towo DOT net>  <20091214171323 DOT GS8059 AT calimero DOT vinschen DOT de>  <20091215130036 DOT GA19394 AT calimero DOT vinschen DOT de>  <4B28ACE8 DOT 1050305 AT towo DOT net>  <20091216145627 DOT GM8059 AT calimero DOT vinschen DOT de>  <4B29934A DOT 80902 AT towo DOT net>  <4B2C0715 DOT 8090108 AT towo DOT net>  <20091221101216 DOT GA5632 AT calimero DOT vinschen DOT de>  <20100125190806 DOT GA9166 AT calimero DOT vinschen DOT de>  <4B5F0585 DOT 9070903 AT towo DOT net> <20100126161036 DOT GA31281 AT calimero DOT vinschen DOT de> <4B718CB8 DOT 7070308 AT towo DOT net> <4B72083C DOT 2090205 AT cwilson DOT fastmail DOT fm> <4B83A73C DOT 1000208 AT towo DOT net> <4B847943 DOT 9030907 AT cwilson DOT fastmail DOT fm> <4B854C3C DOT 1020204 AT towo DOT net>
In-Reply-To: <4B854C3C.1020204@towo.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

Thomas Wolff wrote:
> However, I already sent a bug report to
> linux-kernel AT vger DOT kernel DOT org some months ago and there doesn't seem to
> be anyone behind that mail address who would even care to respond...

Well, lkml is a mailing list.  Like any other high-volume list, you've
got to keep at it -- repost the patch, ping it a few times, etc.

http://lkml.org/lkml/2009/10/18/54

> so I had just hoped to get this upstream this way. Anyway, my updated
> patch (attached) is now without the linux detail.

Thanks.

>> BTW, does this "fix" 'pstree -G'?
>>    
> Unfortunately not. I checked pstree and it is obviously quite buggy
> about terminal handling.

Yep.  It assumes that "well, duh, everybody supports vt100!" and then
tries to access vt100 mode incorrectly.  Nice.

> I also checked the source and it does the wrong
> thing.

I looked at it some time ago, thinking to patch it "correctly" so that
it would use terminfo, check capabilities, etc.

Too ugly for words.

> There are different methods to embed VT100 graphics codes, for short let
> me call them G1 and G0. What pstree sends is:
> G0-on G1-off code G0-off
> Obviously terminals handle this differently. xterm and mintty seem to
> still apply VT100 graphics within G0-on...G0-off despite the stray G1-off,
> while my cygwin console patch doesn't, it just switches it off when it's
> told "off" by one method and I thought that would be OK.
> So there is two options:
> - I could amend my patch with a workaround

Maybe; I'm not sure what TRTTD is.  Up to you.

> - I/We could get pstree fixed, probably upstream?

I think this is more reasonable; it's probably a very simple patch since
you wouldn't be trying to do a full-monty rework all of pstree's term
handling. You'd just be changing one or two sequences.

Corinna is listed as the psmisc package maintainer; I'm sure PTC.

>> I'll adapt and release an update relatively soon. ...
>> I'm guessing that these terminfo changes need to wait until 1.7.2, right?
>>    
> Yes, please.

Ack.

--
Chuck


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple