X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: sourceware.org
Message-ID: <4B318D91.6000602@cwilson.fastmail.fm>
Date: Tue, 22 Dec 2009 22:25:05 -0500
From: Charles Wilson <cygwin AT cwilson DOT fastmail DOT fm>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: libiconv and iconv() prototype
References: <loom DOT 20091222T215756-367 AT post DOT gmane DOT org>
In-Reply-To: <loom.20091222T215756-367@post.gmane.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

Eric Blake wrote:
> The newlib header for iconv.h was recently fixed to comply with the POSIX 
> prototype, but cygwin is still stuck with a bogus const on the second argument 
> of iconv().  It's kind of a catch-22 - libiconv configures itself to preserve 
> the system's prototype, but on cygwin, the system's prototype comes from 
> libiconv, because we do not use newlib's implementation.  So it takes an 
> explicit action while building from source in order to properly get a libiconv 
> installation to use the correct signature; I think it should be possible with:
>  ./configure am_cv_proto_iconv_arg1=
> 
> Any chance we can get a new libiconv-1.13-11 build with the updated signature?

Err...by changing the prototype, doesn't that change the ABI?

-_EXFUN(iconv, (iconv_t, _CONST char **, size_t *, char **, size_t *));
+_EXFUN(iconv, (iconv_t, char **, size_t *, char **, size_t *));

So, are you advocating a new cygiconv-3.dll?  Or am I wrong, and this
change does NOT affect the ABI?

I don't object, if so -- POSIX compliance is a good thing. But I just
want to be sure what I'm jumping into, first.

--
Chuck



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple