X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Wed, 9 Sep 2009 13:42:50 -0400
From: Christopher Faylor <cgf-use-the-mailinglist-please AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: [1.7] rename/renameat error
Message-ID: <20090909174250.GC29151@ednor.casa.cgf.cx>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <4AA52B5E DOT 8060509 AT byu DOT net>  <20090907192046 DOT GA12492 AT calimero DOT vinschen DOT de>  <loom DOT 20090909T005422-847 AT post DOT gmane DOT org>  <loom DOT 20090909T183010-83 AT post DOT gmane DOT org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <loom.20090909T183010-83@post.gmane.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Wed, Sep 09, 2009 at 04:36:39PM +0000, Eric Blake wrote:
>Eric Blake <ebb9 <at> byu.net> writes:
>>>>POSIX states that rename must fail with EINVAL if either argument ends
>>>>in '.' or '..' (after trailing slashes are stripped).  Cygwin 1.7 is
>>>>detecting this situation (which is a step up from 1.5 which did the
>>>>rename anyways), but sets errno to EBUSY instead of EINVAL.
>>>
>>>Thanks for catching.  Feel free to fix the rename function accordingly.
>>
>>OK, I'll look into it (I don't know how large the patch will be, yet).
>
>And link("a","f/.") should not create "f" as a regular file, either.
>I'm still looking at where to patch things.

Argh.  That's a longstanding problem with brain-dead windows behavior.  It's
supposed to be handled in path_conv::check, IIRC.

>Also, we currently allow link("a","b") on FAT, but it might be nicer to fail 
>with EPERM on file systems where hard links are not supported, to match Linux 
>behavior (portable programs, like autoconf, already have fallbacks to perform 
>cp if linking fails, but the copy should be done by the caller, not by link() 
>itself).

We've debated this over the years but I'm ok with not lying to the caller about
performing a link when we really didn't.

cgf

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple