X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: sourceware.org
Message-ID: <4A85A9F3.9090108@cwilson.fastmail.fm>
Date: Fri, 14 Aug 2009 14:16:19 -0400
From: Charles Wilson <cygwin AT cwilson DOT fastmail DOT fm>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.22) Gecko/20090605 Thunderbird/2.0.0.22 Mnenhy/0.7.6.666
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: [ANNOUNCEMENT] Updated: run-1.1.11-1
References: <20090812134355 DOT GB13438 AT calimero DOT vinschen DOT de> <4A82F82C DOT 6000907 AT cwilson DOT fastmail DOT fm> <20090813140610 DOT GI13438 AT calimero DOT vinschen DOT de> <4A84BF50 DOT 3040009 AT cwilson DOT fastmail DOT fm> <20090814063458 DOT GV13438 AT calimero DOT vinschen DOT de> <4A857186 DOT 9040201 AT cwilson DOT fastmail DOT fm> <20090814144442 DOT GF32408 AT calimero DOT vinschen DOT de> <20090814151921 DOT GA28983 AT ednor DOT casa DOT cgf DOT cx> <20090814152904 DOT GG32408 AT calimero DOT vinschen DOT de> <20090814154349 DOT GA10002 AT ednor DOT casa DOT cgf DOT cx> <20090814162049 DOT GH32408 AT calimero DOT vinschen DOT de> <4A859A59 DOT 1040308 AT cwilson DOT fastmail DOT fm>
In-Reply-To: <4A859A59.1040308@cwilson.fastmail.fm>
Content-Type: multipart/mixed;  boundary="------------090906040905030902030006"
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

--------------090906040905030902030006
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Charles Wilson wrote:
> Corinna Vinschen wrote:
>> Actually, what I told above is nonsense anyway.  What I saw was the
>> flickering cmd window from a urxvt-X startup without run.  With run it
>> doesn't start at all for me on W7, unless I start it from an existing
>> console window.  And in that case it doesn't matter if the
>> CREATE_NO_WINDOW flag is given or not, it always takes 100% CPU.  So,
>> scratch that, it's no solution at all.
> 
> Rats.  So much for a "good enough" workaround.

OK, the attached patch (on top of run-1.1.11) seems to correct the
problem in my testing.

For testing, I:
  1) used the W7 "workaround" code, even though I was using Vista.
  2) This caused 100% CPU
  3) then, adding the attached patch, I tried again (with the W7
"workaround" code still enabled) and did NOT see 100% CPU.

So, I'm hopeful that this fixes the problem for real, on W7.  However,
with one exception, the production version of 1.1.12 for <= WinXP will
continue to use the "old" code.  That exception is:

for WinXP and above, I forcibly enabled the used "pipes" -- that is,
explicitly creating new Windows Handles and setting them up as the
child's stdio.  The reason for this is, even the "old" run code would
hit 100% CPU in the following scenario, on WinXP:

   1) from a bash prompt in a cmd window
   2) run urxvt-X.exe -display 127.0.0.1:0.0

gave 100% CPU, although launching urxvt-X from a shortcut using the same
invocation did not do so.  With this small change, that problem is
corrected, too.

Corinna, can you give this a try? (I'm happy to send you a compiled
version of the modified run.exe if that helps).

--
Chuck


--------------090906040905030902030006
Content-Type: application/x-patch;
 name="newfix.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="newfix.patch"

ZGlmZiAtLWdpdCBhL3NyYy9ydW4uYyBiL3NyYy9ydW4uYwppbmRleCAxNzFm
NWQ3Li43MWE2NzhiIDEwMDY0NAotLS0gYS9zcmMvcnVuLmMKKysrIGIvc3Jj
L3J1bi5jCkBAIC0yNzQsNyArMjc0LDcgQEAgQk9PTCBzZXR1cF9pbnZpc2li
bGVfY29uc29sZSgpCiAKIC8qIHJldHVybnMgRkFMU0Ugb25seSBvbiBlcnJv
ciBjb25kaXRpb25zIChub3QgaW1wbCkgKi8KIEJPT0wgY29uZmlndXJlX3N0
YXJ0dXBpbmZvKFNUQVJUVVBJTkZPKiBwc2ksIEJPT0wgYkhhdmVJbnZpc0Nv
bnNvbGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICBCT09MICpiVXNp
bmdQaXBlcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIEJPT0wgYkZv
cmNlVXNpbmdQaXBlcywgQk9PTCAqYlVzaW5nUGlwZXMsCiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBIQU5ETEUqIGhwVG9DaGlsZCwgIEhBTkRMRSog
aHBGcm9tQ2hpbGQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICBIQU5E
TEUqIGhwVG9QYXJlbnQsIEhBTkRMRSogaHBGcm9tUGFyZW50KQogewpAQCAt
Mjk4LDcgKzI5OCw3IEBAIEJPT0wgY29uZmlndXJlX3N0YXJ0dXBpbmZvKFNU
QVJUVVBJTkZPKiBwc2ksIEJPT0wgYkhhdmVJbnZpc0NvbnNvbGUsCiAgICAg
ICogc2hvdWxkIGJlIHJlbW92ZWQuCiAgICAgICovCiAvKgotICAgIGlmIChm
b28oKSkKKyAgICBpZiAoIWJGb3JjZVVzaW5nUGlwZXMgJiYgZm9vKCkpCiAg
ICAgewogICAgICAgICpiVXNpbmdQaXBlcyA9IEZBTFNFOwogICAgICAgIHJl
dHVybiBUUlVFOwpAQCAtMzA4LDcgKzMwOCw3IEBAIEJPT0wgY29uZmlndXJl
X3N0YXJ0dXBpbmZvKFNUQVJUVVBJTkZPKiBwc2ksIEJPT0wgYkhhdmVJbnZp
c0NvbnNvbGUsCiAgICAgLyogYnV0IGZvciBub3csIHRoZSBvbmx5IHdheSB3
ZSBLTk9XIHdlIGhhdmUgYSBjb25zb2xlIGlzCiAgICAgICogaWYgd2UgY3Jl
YXRlZCBpdCBvdXJzZWx2ZXMKICAgICAgKi8KLSAgICBpZiAoYkhhdmVJbnZp
c0NvbnNvbGUpCisgICAgaWYgKCFiRm9yY2VVc2luZ1BpcGVzICYmIGJIYXZl
SW52aXNDb25zb2xlKQogICAgIHsKICAgICAgICAqYlVzaW5nUGlwZXMgPSBG
QUxTRTsKICAgICAgICByZXR1cm4gVFJVRTsKQEAgLTM1MCwxOCArMzUwLDIw
IEBAIGludCBzdGFydF9jaGlsZChjaGFyKiBjbWRsaW5lLCBpbnQgd2FpdF9m
b3JfY2hpbGQpCiAgICBCT09MIGJGdW5jUmV0dXJuOwogICAgQk9PTCBiSGF2
ZUludmlzQ29uc29sZTsKICAgIEJPT0wgYlVzaW5nUGlwZXM7CisgICBCT09M
IGJGb3JjZVVzaW5nUGlwZXMgPSBGQUxTRTsKICAgIEhBTkRMRSBoVG9DaGls
ZCwgaEZyb21DaGlsZDsKICAgIEhBTkRMRSBoVG9QYXJlbnQsIGhGcm9tUGFy
ZW50OwogICAgQk9PTCBXSU5BUEkgKCpBdHRhY2hDb25zb2xlRlApKERXT1JE
KSA9IE5VTEw7CiAgICBIV05EIFdJTkFQSSAoKkdldENvbnNvbGVXaW5kb3dG
UCkoVk9JRCkgPSBOVUxMOworICAgRFdPUkQgY3JlYXRpb25GbGFncyA9IDA7
CiAKICAgIHNldHVwX3dpbl9lbnZpcm9uKCk7CiAKLSNpZiAoZGVmaW5lZCAo
X19DWUdXSU5fXykgJiYgIUhBVkVfREVDTF9DWUdXSU5fQ09OVl9QQVRIKSB8
fCBkZWZpbmVkKF9fTUlOR1czMl9fKQotICAgLyogbWluZ3cgb3IgY3lnd2lu
LTEuNTogd29yayBhcm91bmQgYnVnIGluIFdpbmRvd3MgNywgYnV0IGFsc28K
LSAgICAqIGVtcGxveSBvbiBYUCBhbmQgYWJvdmUuIFRoaXMgbWVhbnMgdGhh
dCBzZXR1cF9pbnZpc2libGVfY29uc29sZSgpCi0gICAgKiBpcyBub3cgdXNl
ZCBvbmx5IG9uIDw9IFdpbjJrICovCi0gICBpZiAob3NfdmVyc2lvbiA+PSAw
eDA1MDEpCisgICAvKiBXb3JrIGFyb3VuZCBidWcgaW4gV2luZG93cyA3LiBG
b3IgVmlzdGEgYW5kIGJlbG93LCBjb250aW51ZQorICAgICogdG8gdXNlIHRo
ZSBtb3JlIHJlbGlhYmxlIHNldHVwX2ludmlzaWJsZV9jb25zb2xlKCkgYW5k
IGl0cworICAgICogc2VwYXJhdGUgV2luZG93U3RhdGlvbiBhcHByb2FjaDsg
Zm9yIFc3IHdlIG5lZWQgdGhlc2UgcG9pbnRlcnMuCisgICAgKi8KKyAgIGlm
IChvc192ZXJzaW9uID49IDB4MDYwMSkKICAgICAgewogICAgICAgIEhNT0RV
TEUgbGliID0gR2V0TW9kdWxlSGFuZGxlICgia2VybmVsMzIuZGxsIik7CiAg
ICAgICAgQXR0YWNoQ29uc29sZUZQID0gKEJPT0wgV0lOQVBJICgqKShEV09S
RCkpCkBAIC0zNzAsMjQgKzM3MiwzMyBAQCBpbnQgc3RhcnRfY2hpbGQoY2hh
ciogY21kbGluZSwgaW50IHdhaXRfZm9yX2NoaWxkKQogICAgICAgICAgICBH
ZXRQcm9jQWRkcmVzcyAobGliLCAiR2V0Q29uc29sZVdpbmRvdyIpOwogICAg
ICAgIGlmICghQXR0YWNoQ29uc29sZUZQIHx8ICFHZXRDb25zb2xlV2luZG93
RlApCiAgICAgICAgICAgIG9zX3ZlcnNpb24gPSAwOwotICAgICB9CisjaWYg
ZGVmaW5lZChfX0NZR1dJTl9fKSAmJiBIQVZFX0RFQ0xfQ1lHV0lOX0NPTlZf
UEFUSAorICAgICAgIC8qIGFuZCBmb3IgY3lnd2luLTEuNywgYWxzbyB0aGlz
LCBiZWNhdXNlIGN5Z3dpbiBrZXJuZWwKKyAgICAgICAgKiB3aWxsIGNyZWF0
ZSBhIGhpZGRlbiBjb25zb2xlIC0tIG9yIGF0dGFjaCBjaGlsZCB0byBhbgor
ICAgICAgICAqIGV4aXN0aW5nIG9uZSAtLSBmb3IgdXMuCisgICAgICAgICov
CisgICAgICAgLyogY3JlYXRpb25GbGFncyB8PSBDUkVBVEVfTk9fV0lORE9X
OyAqLwogI2VuZGlmCisgICAgIH0KIAogI2lmZGVmIERFQlVHX0ZPUkNFX1BJ
UEVTCiAgICBiSGF2ZUludmlzQ29uc29sZSA9IEZBTFNFOworICAgYkZvcmNl
VXNpbmdQaXBlcyA9IFRSVUU7CiAgICBGcmVlQ29uc29sZSgpOwotI2VsaWYg
ZGVmaW5lZCAoX19DWUdXSU5fXykgJiYgSEFWRV9ERUNMX0NZR1dJTl9DT05W
X1BBVEgKLSAgIC8qIGN5Z3dpbi0xLjcgKi8KLSAgIGJIYXZlSW52aXNDb25z
b2xlID0gVFJVRTsKICNlbHNlCi0gICAvKiBtaW5ndyBvciBjeWd3aW4tMS41
OiB3b3JrIGFyb3VuZCBidWcgaW4gV2luZG93cyA3LCBidXQgYWxzbwotICAg
ICogZW1wbG95IG9uIFhQIGFuZCBhYm92ZS4gVGhpcyBtZWFucyB0aGF0IHNl
dHVwX2ludmlzaWJsZV9jb25zb2xlKCkKLSAgICAqIGlzIG5vdyB1c2VkIG9u
bHkgb24gPD0gV2luMmsgKi8KLSAgIGJIYXZlSW52aXNDb25zb2xlID0gb3Nf
dmVyc2lvbiA+PSAweDA1MDEgPyBUUlVFIDogc2V0dXBfaW52aXNpYmxlX2Nv
bnNvbGUoKTsKKyAgIC8qIFdvcmsgYXJvdW5kIGJ1ZyBpbiBXaW5kb3dzIDcu
IEZvciBWaXN0YSBhbmQgYmVsb3csIGNvbnRpbnVlCisgICAgKiB0byB1c2Ug
dGhlIG1vcmUgcmVsaWFibGUgc2V0dXBfaW52aXNpYmxlX2NvbnNvbGUoKSBh
bmQgaXRzCisgICAgKiBzZXBhcmF0ZSBXaW5kb3dTdGF0aW9uIGFwcHJvYWNo
LgorICAgICovCisgICBiSGF2ZUludmlzQ29uc29sZSA9IG9zX3ZlcnNpb24g
Pj0gMHgwNjAxID8gVFJVRSA6IHNldHVwX2ludmlzaWJsZV9jb25zb2xlKCk7
CisgICAvKiBGaXggaXNzdWUgd2l0aCAxMDAlIENQVSB1c2FnZSB3aGVuIGxh
dW5jaGluZyBjZXJ0YWluIGFwcHMgZnJvbQorICAgICogYSBjbWQuZXhlIGJv
eAorICAgICovCisgICBiRm9yY2VVc2luZ1BpcGVzID0gKG9zX3ZlcnNpb24g
Pj0gMHgwNTAxKTsKICNlbmRpZgogCiAgICBpZiAoIWNvbmZpZ3VyZV9zdGFy
dHVwaW5mbygmc3RhcnQsIGJIYXZlSW52aXNDb25zb2xlLAotICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgJmJVc2luZ1BpcGVzLAorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgYkZvcmNlVXNpbmdQaXBlcywgJmJVc2lu
Z1BpcGVzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmhUb0No
aWxkLCAmaEZyb21DaGlsZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICZoVG9QYXJlbnQsICZoRnJvbVBhcmVudCkpCiAgICAgICBlcnJvcigi
Y291bGQgbm90IHN0YXJ0ICVzIixjbWRsaW5lKTsKQEAgLTQwMywxMSArNDE0
LDcgQEAgaW50IHN0YXJ0X2NoaWxkKGNoYXIqIGNtZGxpbmUsIGludCB3YWl0
X2Zvcl9jaGlsZCkKICAgICAgICBOVUxMLCAgICAvKiBwcm9jZXNzIHNlY3Vy
aXR5IGF0dHJpYnV0ZXMgICAgICAgICAqLwogICAgICAgIE5VTEwsICAgIC8q
IHByaW1hcnkgdGhyZWFkIHNlY3VyaXR5IGF0dHJpYnV0ZXMgICovCiAgICAg
ICAgVFJVRSwgICAgLyogaGFuZGxlcyBhcmUgaW5oZXJpdGVkLCAgICAgICAg
ICAgICAgKi8KLSNpZiBkZWZpbmVkKF9fQ1lHV0lOX18pICYmIEhBVkVfREVD
TF9DWUdXSU5fQ09OVl9QQVRICi0gICAgICAgQ1JFQVRFX05PX1dJTkRPVywK
LSNlbHNlCi0gICAgICAgMCwgICAgICAgLyogY3JlYXRpb24gZmxhZ3MgICAg
ICAgICAgICAgICAgICAgICAgKi8KLSNlbmRpZgorICAgICAgIGNyZWF0aW9u
RmxhZ3MsIC8qIGNyZWF0aW9uIGZsYWdzICAgICAgICAgICAgICAgICovCiAg
ICAgICAgTlVMTCwgICAgLyogdXNlIHBhcmVudCdzIGVudmlyb25tZW50ICAg
ICAgICAgICAgKi8KICAgICAgICBOVUxMLCAgICAvKiB1c2UgcGFyZW50J3Mg
Y3VycmVudCBkaXJlY3RvcnkgICAgICAqLwogICAgICAgICZzdGFydCwgIC8q
IFNUQVJUVVBJTkZPIHBvaW50ZXIgICAgICAgICAgICAgICAgICovCkBAIC00
NDgsMTcgKzQ1NSwxOCBAQCBpbnQgc3RhcnRfY2hpbGQoY2hhciogY21kbGlu
ZSwgaW50IHdhaXRfZm9yX2NoaWxkKQogICAgICAgICAgIH0KICAgICAgICAg
ICBHZXRFeGl0Q29kZVByb2Nlc3MgKGNoaWxkLmhQcm9jZXNzLCAmcmV0dmFs
KTsKICAgICAgIH0KLSNpZiAoZGVmaW5lZChfX0NZR1dJTl9fKSAmJiAhSEFW
RV9ERUNMX0NZR1dJTl9DT05WX1BBVEgpIHx8IGRlZmluZWQoX19NSU5HVzMy
X18pCi0gICAgIC8qIG1pbmd3IG9yIGN5Z3dpbi0xLjU6IHdvcmsgYXJvdW5k
IGJ1ZyBpbiBXaW5kb3dzIDcsIGJ1dCBhbHNvCi0gICAgICAqIGVtcGxveSBv
biBYUCBhbmQgYWJvdmUuIFRoaXMgbWVhbnMgdGhhdCBzZXR1cF9pbnZpc2li
bGVfY29uc29sZSgpCi0gICAgICAqIGlzIG5vdyB1c2VkIG9ubHkgb24gPD0g
V2luMmsgKi8KLSAgICAgIGlmIChvc192ZXJzaW9uID49IDB4MDUwMSkKKwor
ICAgICAgLyogV29yayBhcm91bmQgYnVnIGluIFdpbmRvd3MgNy4gRm9yIFZp
c3RhIGFuZCBiZWxvdywgY29udGludWUKKyAgICAgICAqIHRvIHVzZSB0aGUg
bW9yZSByZWxpYWJsZSBzZXR1cF9pbnZpc2libGVfY29uc29sZSgpIGFuZCBp
dHMKKyAgICAgICAqIHNlcGFyYXRlIFdpbmRvd1N0YXRpb24gYXBwcm9hY2gu
CisgICAgICAgKi8KKyAgICAgIGlmIChvc192ZXJzaW9uID49IDB4MDYwMSkK
ICAgICAgIHsKICAgICAgICAgRnJlZUNvbnNvbGUgKCk7CiAgICAgICAgICgq
QXR0YWNoQ29uc29sZUZQKSAoY2hpbGQuZHdQcm9jZXNzSWQpOwogICAgICAg
ICBTZXRQYXJlbnQgKCgqR2V0Q29uc29sZVdpbmRvd0ZQKSAoKSwgSFdORF9N
RVNTQUdFKTsKICAgICAgIH0KLSNlbmRpZgorCiAgICAgICBDbG9zZUhhbmRs
ZSAoY2hpbGQuaFRocmVhZCk7CiAgICAgICBDbG9zZUhhbmRsZSAoY2hpbGQu
aFByb2Nlc3MpOwogICAgICAgaWYgKGJVc2luZ1BpcGVzKQo=


--------------090906040905030902030006
Content-Type: text/plain; charset=us-ascii

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
--------------090906040905030902030006--