X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Thu, 23 Jul 2009 10:03:08 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: csih: Patch getVolInfo.c
Message-ID: <20090723080308.GV27613@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <20090722185402 DOT GS27613 AT calimero DOT vinschen DOT de> <20090722192657 DOT GU27613 AT calimero DOT vinschen DOT de> <loom DOT 20090722T195138-214 AT post DOT gmane DOT org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <loom.20090722T195138-214@post.gmane.org>
User-Agent: Mutt/1.5.19 (2009-02-20)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Jul 22 19:54, Eric Blake wrote:
> Corinna Vinschen <corinna-cygwin <at> cygwin.com> writes:
> 
> > > However, for access to the filesystem information, the READ_CONTROL
> > > isn't necessary.  A desired access of 0 is sufficient in every case
> > > I could lay my hands on (NTFS, NFS, Samba, FAT32, HGFS).
> > > 
> > along these lines, can you please test the change to mount.cc on MVFS?
> 
> Seeing as how you aren't in a position to lay your hands on MVFS, I get to be 
> the bearer of bad news.
> 
> You'll have to recode this to do a retry loop, since MVFS rejects NtOpenFile 
> with access of 0, giving status 0xc0000022.  The only question now is whether 
> you should do the READ_CONTROL first and retry to 0, or 0 first and 
> READ_CONTROL as the retry.
> 
> > It would be a pity if MVFS would be broken again due to this change,
> > after having gone through all the hassle of the last days.
> 
> And of course, with 'df -T mvfs/file' now showing "unknown" instead of "mvfs", 
> you can imagine what else broke.

Ok, I reverted the change and now, if opening with READ_CONTROL fails,
I try with FILE_READ_DATA, just like GetVolumeInformation.  That should
really do it once and for all(*).


Thanks for teting,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple