X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Tue, 21 Jul 2009 10:10:47 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: MVFS results
Message-ID: <20090721081047.GV27613@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <loom DOT 20090715T192219-408 AT post DOT gmane DOT org> <20090715204831 DOT GA27613 AT calimero DOT vinschen DOT de> <loom DOT 20090715T213245-387 AT post DOT gmane DOT org> <loom DOT 20090717T230701-727 AT post DOT gmane DOT org> <20090718101123 DOT GA8581 AT calimero DOT vinschen DOT de> <loom DOT 20090720T142924-486 AT post DOT gmane DOT org> <20090720153636 DOT GQ27613 AT calimero DOT vinschen DOT de> <loom DOT 20090720T154622-451 AT post DOT gmane DOT org> <20090720174912 DOT GT27613 AT calimero DOT vinschen DOT de> <loom DOT 20090720T200138-134 AT post DOT gmane DOT org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <loom.20090720T200138-134@post.gmane.org>
User-Agent: Mutt/1.5.19 (2009-02-20)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Jul 20 20:13, Eric Blake wrote:
> SUCCESS!  The following patch works for both read-only and writeable files.  
> Doing the work on the original handle is not enough - it has to be flushed to 
> disk so as not to be lost by later state changes.  And doing the work on the 
> duplicate is not enough, since based on the procmon output, it looks like MVFS 
> caches information per handle, and with no reason to invalidate that cache, it 
> will just overwrite the disk state on close.  But the combination of working on 
> the duplicate handle to flush the change to disk, followed by repeating the 
> action on the original handle, is enough to force MVFS to realize that we meant 
> business.  And BOTH utimens and fchmod need this treatment (utimens alone fixed 
> the writable file case, but not the read-only case).

How cute.  I have reworked the patch slightly to encapsulate the MVFS
code somewhat more.  I've checked it in.  Please try if it still works
as advertised.


Thanks for the thorough testing,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple