Date: Mon, 23 Feb 2009 19:51:57 -0500
From: Christopher Faylor <cgf-use-the-mailinglist-please AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Makefile.in respect $(DESTDIR) - Patch applied
Message-ID: <20090224005157.GA10047@ednor.casa.cgf.cx>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <49A2DA22 DOT 4090708 AT dazjorz DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49A2DA22.4090708@dazjorz.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com

On Mon, Feb 23, 2009 at 06:17:22PM +0100, Sjors Gielen wrote:
> Hello,
>
> I noticed winsup does not respect $(DESTDIR) in its installation process. 
> The applied patch modifies the Makefile.in files, to have them use 
> $(DESTDIR) in all install lines. This includes:
>    * install(1)   (also MKDIRP)
>    * the mkinstalldirs / $(mkinstalldirs) commands
>    * a ln -sf line
> I may have forgotten some, however the following commands show the patch 
> works:
>
>    build$ ../src/configure --prefix=/tmp/wrongplace
>    build$ make
>    build$ make install DESTDIR=/tmp/rightplace
>
> This correctly installs all files to /tmp/rightplace/tmp/wrongplace, 
> /tmp/wrongplace is never created. newlib already respects DESTDIR in its 
> makefiles (it does use automake). This patch applies cleanly to the current 
> CVS revision.
>
> After applying this patch, the commands in FAQ section 6.18 "How do I build 
> Cygwin on my own" can be changed to:
>
>   mkdir build install;
>   cd build;
>   (../src/configure --prefix= -v; make) >& make.out
>   make install DESTDIR=../install > install.log 2>&1
>
> After these commands, all files are in ../install and configured to be 
> installed in / (prefix is empty, i.e. / without the last slash). In my 
> opinion, this is a cleaner way to compile Cygwin than giving 
> --prefix=../install to configure.

Thanks for the patch.  I've had something half-finished sitting in my sandbox
for a while now but since you beat me to it, I'll install your version.

I'm not going to change the mingw/w32api stuff though.  That belongs to
another project.  You might want to visit http://mingw.org/ and find a
forum which is appropriate to ask them if your changes are ok.

(Unless one of them is reading this and can speak definitively of course)

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/