X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Wed, 20 Aug 2008 15:42:09 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: [ANNOUNCEMENT] Updated: csih-0.1.7-1
Message-ID: <20080820134209.GN29104@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <announce DOT 48A789B6 DOT 3010103 AT cwilson DOT fastmail DOT fm> <48A78C6F DOT 2050403 AT cwilson DOT fastmail DOT fm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48A78C6F.2050403@cwilson.fastmail.fm>
User-Agent: Mutt/1.5.16 (2007-06-09)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

Hi Chuck,

On Aug 16 22:26, Charles Wilson wrote:
> Corinna --
> 
> Attached see
> 
> (1) bugfix for ssh-user-config -- self-explanatory.
> 
> (2) behavior enhancement for ssh-host-config
> 
> Takes advantage of new functions and cleans up behavior under 1.7
>   -- esp. 'mount' doesn't have a -t option anymore, so we need
>      another mechanism to deal with the dos-format
>      WINDOWS/system32/drivers/etc/services file
> 
> Should still work fine under 1.5
> Requires csih-0.1.17 (uses new function csih_cygver_is_oneseven)

I'm about to create a new openssh package for 1.7 with fixes along the
lines of what you sent in your OP.

While I'm at it, I see that there's a bit of dual work in the
csih-0.1.7 script and the ssh-host-config script:

/usr/share/csih/cygwin-service-installation-helper.sh, func _csih_setup:

  csih_make_dir "${LOCALSTATEDIR}/run"
  csih_make_dir "${LOCALSTATEDIR}/log"
  csih_make_dir "${LOCALSTATEDIR}/empty"
  [... checking permissions ...]
  csih_make_dir "${SYSCONFDIR}"

/bin/ssh-host-config:

  csih_make_dir "${SYSCONFDIR}" "Cannot create global configuration files."
  chmod 775 "${SYSCONFDIR}"
  setfacl -m u:system:rwx "${SYSCONFDIR}"

  csih_make_dir "${LOCALSTATEDIR}/log" "Cannot create log directory."
  chmod 1777 "${LOCALSTATEDIR}/log"
  setfacl -m u:system:rwx "${LOCALSTATEDIR}/log"

I would like to propose to do all the work in the csih script, like
this:

  csih_make_dir "${LOCALSTATEDIR}/run"
  chmod 1777 "${LOCALSTATEDIR}/run"
  csih_make_dir "${LOCALSTATEDIR}/log"
  chmod 1777 "${LOCALSTATEDIR}/log"
  csih_make_dir "${LOCALSTATEDIR}/empty"
  chmod 755 "${LOCALSTATEDIR}/empty"
  [... checking permissions ...]
  csih_make_dir "${SYSCONFDIR}"
  chmod 755 "${LOCALSTATEDIR}/etc"

The /var dirs are now (setup 2.609) created with 01777 permissions
anyway, but it can't hurt to keep this code in.  The 01777 permissions
make sure that all daemons can create their files in /var/run, /var/log.

The code in /bin/ssh-host-config would go away entirely.  The script
would also test for the *next* csih version 0.1.8.

Sounds good?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/