X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Mon, 18 Feb 2008 13:09:56 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: AW: 1.5.25-7 piping directed output to /dev/stdout will not 	work
Message-ID: <20080218120956.GF28455@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <4971562D0CDBAE4A86212E08861E9C4F038D779E AT si-mail46 DOT de DOT bosch DOT com> <47B59B10 DOT 5090105 AT byu DOT net> <4971562D0CDBAE4A86212E08861E9C4F038D77A3 AT si-mail46 DOT de DOT bosch DOT com> <47B66A3F DOT 4030804 AT byu DOT net> <20080216095212 DOT GA9304 AT calimero DOT vinschen DOT de> <47B6E2B3 DOT 9010701 AT byu DOT net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47B6E2B3.9010701@byu.net>
User-Agent: Mutt/1.5.16 (2007-06-09)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Feb 16 06:18, Eric Blake wrote:
> The symlink was correctly resolved, and discovered the pipe, but fell back
> to fhandler_base::dup to do the duplication.  At any rate, the open
> succeeded, but fd 3 is now tied to a symbolic name
> (/proc/3448/fd/pipe:[1504] stands for handle 0x5e0).  Then, in the dup2,
> handle 0x5e0 from fd 1 is closed before overlaying fd 3 onto fd 1.
> Finally, the write tries to access the pipe via fd 1, and sends a wakeup
> to the original handle 0x5e0, based on the symbolic name associated with
> fd 3 (now fd 1) - oops; that was the handle that dup already closed.

This might be a bug in the pipe handling, I'm not sure, but the name
associated with the file descriptor is certainly not the reason to access
the 5e0 handle.

> Here, the strace inherits an open handle to f, but does not know which
> file it came from, so it gives up with ENOENT rather than successfully
> creating fd 3.  But since strace is obviously able to dup open handles to
> unknown files, it would seem that open(/proc/self/fd/1) to an unknown file
> handle should work as well.

strace doesn't call dup.  Rather it just inherits the stdio file handles
to the child through the call to CreateProcess.  What you get is a fd 1
in foo which is connected to an unknown file.  Calling open("/dev/stdout")
results in a symlink expansion which points into nirvana.  The open call
fails before it even tries to call an fhandler's open method.

> Not /dev/stdout, per se, but /proc/<pid>/fd/n.  But since /proc is already
> a special device (via fhandler_proc), it seems like such special handling
> should already be happening.  Maybe it's just a matter of writing
> fhandler_proc::dup, or making fhandler_proc::open go through the dup
> machinery.

open ("/dev/stdout") goes through the entire symlink expansion first.
fhandler_process is not involved in the open() call, except in the
symlink expansion stage.  The final path is the path to the pipe. 
Consequentially the open is done by fhandler_pipe::open.  It already
knows when it's opening a pipe of the current process and it calls dup().

dup2 is implemented in the outer layer, dtable::dup2.  It has no
knowledge about the underlying types of file handlers and usually
doesn't need any.  If the target descriptor is opened, it closes it
after duplicating the source handle worked.  I don't see that any
special handling at this point would make any sense.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/