X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
To: cygwin AT cygwin DOT com
From: Diego Biurrun <diego AT biurrun DOT de>
Subject:  Re: llrint implementation in Cygwin
Date:  Sat, 29 Sep 2007 22:20:23 +0200
Lines: 47
Message-ID: <fdmc2b$con$1@sea.gmane.org>
References:  <fd68u2$geo$1 AT sea DOT gmane DOT org> <46F6C151 DOT 3070301 AT computer DOT org>   <fdif1q$efv$1 AT sea DOT gmane DOT org> <Pine DOT GSO DOT 4 DOT 63 DOT 0709280802020 DOT 16275 AT access1 DOT cims DOT nyu DOT edu>  <fdm873$2oj$1 AT sea DOT gmane DOT org> <Pine DOT GSO DOT 4 DOT 63 DOT 0709291533000 DOT 27776 AT access1 DOT cims DOT nyu DOT edu>
Mime-Version:  1.0
Content-Type:  text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding:  7bit
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.8b) Gecko/20050217
In-Reply-To: <Pine.GSO.4.63.0709291533000.27776@access1.cims.nyu.edu>
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

Igor Peshansky wrote:
> On Sat, 29 Sep 2007, Diego Biurrun wrote:
> 
>>Igor Peshansky wrote:
>>
>>>On Fri, 28 Sep 2007, Diego Biurrun wrote:
>>
>>>>I understand that adding llrint to Cygwin is probably not hard at
>>>>all for somebody familiar with Cygwin.  However, I am not such a
>>>>person and I don't even have a Windows environment around to test
>>>>any modifications I might make.
> 
> Cygwin uses newlib as-is for most such functionality.  So, patching
> newlib to include llrint would automatically make Cygwin support it.
> 
> Also, newlib builds on Linux just as well as it does on Windows...

OK, that's useful information, thank you.  In the unlikely event that I 
find some time to dedicate to this I might actually be motivated to have 
a go at this.

>>>>We are about to make an MPlayer release and unfortunately it will
>>>>not compile on Cygwin due to the missing llrint.  I would appreciate
>>>>to know if this is going to get addressed so that I can put an
>>>>appropriate comment in the release notes.
>>>
>>>What's wrong with adding llrint to your code (perhaps with a #define,
>>>i.e.,
>>>
>>>#define llrint my_llrint
>>>typeof(llrint) my_llrint(...) { ... }
>>>
>>>)?
>>
>>It is ugly and it is a workaround for a problem that should be solved
>>outside of FFmpeg.  Should every project using llrint add that
>>workaround?  No, Cygwin should be fixed.
> 
> Fair enough.  I agree that it's ugly, but ultimately it's your call --
> whether you want your project to compile on Cygwin or whether you want to
> require the feature that's missing and accept that Cygwin compilation will
> be broken for a while.

llrint is required, so I guess Cygwin compilation will indeed be broken 
for a while.  We don't add OS-specific workarounds to FFmpeg.

Diego


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/