X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Sat, 29 Sep 2007 15:38:04 -0400 (EDT)
From: Igor Peshansky <pechtcha AT cs DOT nyu DOT edu>
Reply-To: cygwin AT cygwin DOT com
To: Diego Biurrun <diego AT biurrun DOT de>
cc: cygwin AT cygwin DOT com
Subject: Re: llrint implementation in Cygwin
In-Reply-To: <fdm873$2oj$1@sea.gmane.org>
Message-ID: <Pine.GSO.4.63.0709291533000.27776@access1.cims.nyu.edu>
References: <fd68u2$geo$1 AT sea DOT gmane DOT org> <46F6C151 DOT 3070301 AT computer DOT org>   <fdif1q$efv$1 AT sea DOT gmane DOT org> <Pine DOT GSO DOT 4 DOT 63 DOT 0709280802020 DOT 16275 AT access1 DOT cims DOT nyu DOT edu>  <fdm873$2oj$1 AT sea DOT gmane DOT org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Sat, 29 Sep 2007, Diego Biurrun wrote:

> Igor Peshansky wrote:
> > On Fri, 28 Sep 2007, Diego Biurrun wrote:
>
> > > I understand that adding llrint to Cygwin is probably not hard at
> > > all for somebody familiar with Cygwin.  However, I am not such a
> > > person and I don't even have a Windows environment around to test
> > > any modifications I might make.

Cygwin uses newlib as-is for most such functionality.  So, patching
newlib to include llrint would automatically make Cygwin support it.

Also, newlib builds on Linux just as well as it does on Windows...

> > > We are about to make an MPlayer release and unfortunately it will
> > > not compile on Cygwin due to the missing llrint.  I would appreciate
> > > to know if this is going to get addressed so that I can put an
> > > appropriate comment in the release notes.
> >
> > What's wrong with adding llrint to your code (perhaps with a #define,
> > i.e.,
> >
> > #define llrint my_llrint
> > typeof(llrint) my_llrint(...) { ... }
> >
> > )?
>
> It is ugly and it is a workaround for a problem that should be solved
> outside of FFmpeg.  Should every project using llrint add that
> workaround?  No, Cygwin should be fixed.

Fair enough.  I agree that it's ugly, but ultimately it's your call --
whether you want your project to compile on Cygwin or whether you want to
require the feature that's missing and accept that Cygwin compilation will
be broken for a while.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_	    pechtcha AT cs DOT nyu DOT edu | igor AT watson DOT ibm DOT com
ZZZzz /,`.-'`'    -.  ;-;;,_		Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'		old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Belief can be manipulated.  Only knowledge is dangerous.  -- Frank Herbert

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/