X-Spam-Check-By: sourceware.org Date: Thu, 5 Jul 2007 20:15:22 -0400 From: Christopher Faylor To: cygwin AT cygwin DOT com Subject: Re: bug in cygwin_conv_to_posix_path() caused by period in win32 path Message-ID: <20070706001522.GB22578@ednor.casa.cgf.cx> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com References: <468A1024 DOT 8000007 AT mff DOT cuni DOT cz> <468A441A DOT 2000009 AT cygwin DOT com> <468B657B DOT 3050306 AT mff DOT cuni DOT cz> <20070704213927 DOT GC16838 AT trixie DOT casa DOT cgf DOT cx> <468D70E6 DOT 4070403 AT mff DOT cuni DOT cz> <468D75C5 DOT 5050507 AT cygwin DOT com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <468D75C5.5050507@cygwin.com> User-Agent: Mutt/1.5.15 (2007-04-06) Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com On Thu, Jul 05, 2007 at 06:50:45PM -0400, Larry Hall (Cygwin) wrote: > Pavel Kudrna wrote: >>Christopher Faylor wrote: >>>I suppose it is possible that we'd consider a nicely written, minimally >>>intrusive patch to use these but I'm not 100% certain that it is even >>>possible to do this cleanly given the way the environment variable/path >>>conversion handling works. > >>Lets look back to original subject. Function >>cygwin_conv_to_posix_path() should not leave passed win32 path almost >>unconverted: c:.\ -> c:./ c:. -> c:. That is clearly incorrect. I >>found the present meaning of "C:" defined as "C:\" at the beginning of >>path.cc file. So both paths should be converted to /cygdrive/c. But I >>see it much better to convert it according to the contents "!C:" >>environment variable. Even in the present time when these variables >>are without changing inherited between cygwin programs. > >I believe Chris was suggesting that if you didn't like the current >behavior, it's a situation. Someone >interested in pursuing this should approach it with care however, since >the path handling code is sensitive code and introducing even the >slightest inefficiency can cause lots of pain for Cygwin users. Correct. It's puzzling to me what I said which would trigger another round of explanations. The issue is well understood and there is no reason to send more email about this unless the email contains a patch. cgf -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/