X-Spam-Check-By: sourceware.org Subject: [perl #43285] Win32API::File tests language specific From: "Reini Urban via RT" Reply-To: perlbug-followup AT perl DOT org In-Reply-To: References: <5 DOT 9 DOT 5_3508_1182459758 AT reini> <9b18b3110706220330k22e8c5eaq79814cb4cc4f868d AT mail DOT gmail DOT com> <9b18b3110706220525r390dfd46jc5f1636016d0ed65 AT mail DOT gmail DOT com> Message-ID: X-RT-Loop-Prevention: perl RT-Ticket: perl #43285 Managed-by: RT 3.6.HEAD (http://www.bestpractical.com/rt/) RT-Originator: rurban AT x-ray DOT at To: cygwin AT cygwin DOT com MIME-Version: 1.0 X-RT-Original-Encoding: utf-8 Content-type: multipart/mixed; boundary="----------=_1182622507-1276-46" Date: Sat, 23 Jun 2007 11:15:07 -0700 Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com ------------=_1182622507-1276-46 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Attached patch switches to error numbers to handle various foreign languages. On Fri Jun 22 05:25:57 2007, demerphq wrote: > On 6/21/07, Reini Urban via RT at perl.org> wrote: > > Sorry 'bout the subject. Please change to > > "Win32API::File tests language specific" > > > > Attached is a patch to add german. And to beautify the output by adding > > File::Spec. > > > > We should check for the system locale and if not english or german (new) > > switch to numbers by using Win32API::File::_fileLastError(). > > Actually id like to switch to using error numbers only. Theres no > point in supporting a few languages and also error codes. Error codes > alone should be sufficient. > > So id prefer to see this patch changed to just use error codes and > ditch the language parsing outright. > > cheers, > Yves -- Reini Urban ------------=_1182622507-1276-46 Content-Type: application/octet-stream; name="pl-#43285-Win32API-File-t.patch" Content-Disposition: inline; filename="pl-#43285-Win32API-File-t.patch" Content-Transfer-Encoding: base64 RT-Attachment: 43285/264706/115815 LS0tIGV4dC9XaW4zMkFQSS9GaWxlL3QvZmlsZS50Lm9yaWcJMjAwNy0wMi0y OCAwOToxNDowOS4wMDAwMDAwMDAgKzAwMDAKKysrIGV4dC9XaW4zMkFQSS9G aWxlL3QvZmlsZS50CTIwMDctMDYtMjMgMTg6MDk6MjcuNDY4NzUwMDAwICsw MDAwCkBAIC0yLDYgKzIsOCBAQAogIyBCZWZvcmUgYG1ha2UgaW5zdGFsbCcg aXMgcGVyZm9ybWVkIHRoaXMgc2NyaXB0IHNob3VsZCBiZSBydW5uYWJsZSB3 aXRoCiAjIGBtYWtlIHRlc3QnLiBBZnRlciBgbWFrZSBpbnN0YWxsJyBpdCBz aG91bGQgd29yayBhcyBgcGVybCB0ZXN0LnBsJwogCisjIFRoZXNlIHRlc3Qg d2lsbCBvbmx5IHdvcmsgb24gYW4gZW5nbGlzaCBvciBnZXJtYW4gV2luZG93 cyEKKwogIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyBXZSBzdGFydCB3aXRo IHNvbWUgYmxhY2sgbWFnaWMgdG8gcHJpbnQgb24gZmFpbHVyZS4KIAogQkVH SU4gewpAQCAtMjMsNyArMjUsOSBAQAogIyBXaW4zMkFQSTo6RmlsZSBkb2Vz IGFuIGltcGxpY2l0ICJyZXF1aXJlIFdpbjMyIiwgYnV0CiAjIHRoZSAuLi9s aWIgZGlyZWN0b3J5IGluIEBJTkMgd2lsbCBubyBsb25nZXIgd29yayBvbmNl CiAjIHdlIGNoZGlyKCkgaW50byB0aGUgVEVNUCBkaXJlY3RvcnkuCisKIHVz ZSBXaW4zMjsKK3VzZSBGaWxlOjpTcGVjOwogdXNlIENhcnA7CiB1c2UgQ2Fy cDo6SGVhdnk7CiAKQEAgLTM3LDE5ICs0MSwxNiBAQAogCiB1c2Ugc3RyaWN0 IHF3KHN1YnMpOwogCi0kdGVtcD0gJEVOVnsiVE1QIn07Ci0kdGVtcD0gJEVO VnsiVEVNUCJ9CXVubGVzcyAtZCAkdGVtcDsKLSR0ZW1wPSAiQzovVGVtcCIJ dW5sZXNzIC1kICR0ZW1wOwotJHRlbXA9ICIuIgkJdW5sZXNzIC1kICR0ZW1w OworJHRlbXA9IEZpbGU6OlNwZWMtPnRtcGRpcigpOwogJGRpcj0gIlczMkFw aUYudG1wIjsKIAogJEVOVntXSU5ESVJ9ID0gJEVOVntTWVNURU1ST09UfSBp ZiBub3QgZXhpc3RzICRFTlZ7V0lORElSfTsKIAogY2hkaXIoICR0ZW1wICkK ICAgb3IgIGRpZSAiIyBDYW4ndCBjZCB0byB0ZW1wIGRpcmVjdG9yeSwgJHRl bXA6ICQhXG4iOwotCiskdGVtcGRpciA9IEZpbGU6OlNwZWMtPmNhdGRpcigk dGVtcCwkZGlyKTsKIGlmKCAgLWQgJGRpciAgKSB7Ci0gICAgcHJpbnQgIiMg ZGVsZXRpbmcgJHRlbXBcXCRkaXJcXCpcbiIgaWYgZ2xvYiAiJGRpci8qIjsK KyAgICBwcmludCAiIyBkZWxldGluZyAiLEZpbGU6OlNwZWMtPmNhdGRpcigk dGVtcCwkZGlyLCcqJyksIlxuIiBpZiBnbG9iICIkZGlyLyoiOwogCiAgICAg Zm9yIChnbG9iICIkZGlyLyoiKSB7CiAJY2htb2QgMDc3NywgJF87CkBAIC01 OCwxMyArNTksMTIgQEAKICAgICBybWRpciAkZGlyIG9yIGRpZSAiQ291bGQg bm90IHJtZGlyICRkaXI6ICQhIjsKIH0KIG1rZGlyKCAkZGlyLCAwNzc3ICkK LSAgb3IgIGRpZSAiIyBDYW4ndCBjcmVhdGUgdGVtcCBkaXIsICR0ZW1wLyRk aXI6ICQhXG4iOwotcHJpbnQgIiMgY2hkaXIgJHRlbXBcXCRkaXJcbiI7Cisg IG9yICBkaWUgIiMgQ2FuJ3QgY3JlYXRlIHRlbXAgZGlyLCAkdGVtcGRpcjog JCFcbiI7CitwcmludCAiIyBjaGRpciAkdGVtcGRpclxuIjsKIGNoZGlyKCAk ZGlyICkKLSAgb3IgIGRpZSAiIyBDYW4ndCBjZCB0byBteSBkaXIsICR0ZW1w LyRkaXI6ICQhXG4iOwotCisgIG9yICBkaWUgIiMgQ2FuJ3QgY2QgdG8gbXkg ZGlyLCAkdGVtcGRpcjogJCFcbiI7CiAkaDE9IGNyZWF0ZUZpbGUoICJSZWFk T25seS50eHQiLCAiciIsIHsgQXR0cmlidXRlcz0+InIiIH0gKTsKLSRvaz0g ICEgJGgxICAmJiAgZmlsZUxhc3RFcnJvcigpID1+IC9ub3QgZmluZCB0aGUg ZmlsZT8vaTsKKyRvaz0gICEgJGgxICAmJiAgV2luMzJBUEk6OkZpbGU6Ol9m aWxlTGFzdEVycm9yKCkgPT0gMjsgIyBjb3VsZCBub3QgZmluZCB0aGUgZmls ZQogJG9rIG9yIHByaW50ICIjICIsIiIuZmlsZUxhc3RFcnJvcigpLCJcbiI7 CiBwcmludCAkb2sgPyAiIiA6ICJub3QgIiwgIm9rICIsICsrJHRlc3QsICJc biI7CSMgb2sgMgogaWYoICAhICRvayAgKSB7ICAgQ2xvc2VIYW5kbGUoJGgx KTsgICB1bmxpbmsoIlJlYWRPbmx5LnR4dCIpOyAgIH0KQEAgLTc4LDEzICs3 OCwxMyBAQAogcHJpbnQgJG9rID8gIiIgOiAibm90ICIsICJvayAiLCArKyR0 ZXN0LCAiXG4iOwkjIG9rIDQKIAogJGgyPSBjcmVhdGVGaWxlKCAiUmVhZE9u bHkudHh0IiwgInJjbiIgKTsKLSRvaz0gISAkaDIgICYmICBmaWxlTGFzdEVy cm9yKCkgPX4gL2ZpbGUgZXhpc3RzPy9pOworJG9rPSAhICRoMiAgJiYgIFdp bjMyQVBJOjpGaWxlOjpfZmlsZUxhc3RFcnJvcigpID09IDgwOyAjIGZpbGUg ZXhpc3RzCiAkb2sgb3IgcHJpbnQgIiMgIixmaWxlTGFzdEVycm9yKCksIlxu IjsKIHByaW50ICRvayA/ICIiIDogIm5vdCAiLCAib2sgIiwgKyskdGVzdCwg IlxuIjsJIyBvayA1CiBpZiggICEgJG9rICApIHsgICBDbG9zZUhhbmRsZSgk aDIpOyAgIH0KIAogJGgyPSBjcmVhdGVGaWxlKCAiUmVhZE9ubHkudHh0Iiwg InJ3a2UiICk7Ci0kb2s9ICEgJGgyICAmJiAgZmlsZUxhc3RFcnJvcigpID1+ IC9hY2Nlc3MgaXMgZGVuaWVkPy9pOworJG9rPSAhICRoMiAgJiYgIFdpbjMy QVBJOjpGaWxlOjpfZmlsZUxhc3RFcnJvcigpID09IDU7ICMgYWNjZXNzIGlz IGRlbmllZAogJG9rIG9yIHByaW50ICIjICIsZmlsZUxhc3RFcnJvcigpLCJc biI7CiBwcmludCAkb2sgPyAiIiA6ICJub3QgIiwgIm9rICIsICsrJHRlc3Qs ICJcbiI7CSMgb2sgNgogaWYoICAhICRvayAgKSB7ICAgQ2xvc2VIYW5kbGUo JGgyKTsgICB9CkBAIC0xMjEsNyArMTIxLDcgQEAKIHByaW50ICRvayA/ICIi IDogIm5vdCAiLCAib2sgIiwgKyskdGVzdCwgIlxuIjsJIyBvayAxMgogCiAk b2s9ICEgUmVhZEZpbGUoICRoMiwgJHRleHQsIDgwLCAkbGVuLCBbXSApCi0g JiYgIGZpbGVMYXN0RXJyb3IoKSA9fiAvaGFuZGxlIGlzIGludmFsaWQ/L2k7 CisgJiYgIFdpbjMyQVBJOjpGaWxlOjpfZmlsZUxhc3RFcnJvcigpID09IDY7 ICMgaGFuZGxlIGlzIGludmFsaWQKICRvayBvciBwcmludCAiIyAiLGZpbGVM YXN0RXJyb3IoKSwiXG4iOwogcHJpbnQgJG9rID8gIiIgOiAibm90ICIsICJv ayAiLCArKyR0ZXN0LCAiXG4iOwkjIG9rIDEzCiAKQEAgLTE3NCw3ICsxNzQs NyBAQAogfQogZWxzZSB7CiAgICAgdW5saW5rKCJDYW5Xcml0ZS50eHQiKTsK LSAgICAkb2s9IC1lICJDYW5Xcml0ZS50eHQiICYmICAkISA9fiAvcGVybWlz c2lvbiBkZW5pZWQvaTsKKyAgICAkb2sgPSAtZSAiQ2FuV3JpdGUudHh0IiAm JiAgJCEgPX4gL3Blcm1pc3Npb24gZGVuaWVkL2k7CiAgICAgJG9rIG9yIHBy aW50ICIjICQhXG4iOwogfQogcHJpbnQgJG9rID8gIiIgOiAibm90ICIsICJv ayAiLCArKyR0ZXN0LCAiJHNraXBcbiI7ICMgb2sgMjIKQEAgLTE4NCwzNyAr MTg0LDM3IEBACiBDbG9zZUhhbmRsZSggJGgxICk7CiAKICRvaz0gISBEZWxl dGVGaWxlKCAiUmVhZE9ubHkudHh0IiApCi0gJiYgIGZpbGVMYXN0RXJyb3Io KSA9fiAvYWNjZXNzIGlzIGRlbmllZD8vaTsKKyAmJiAgV2luMzJBUEk6OkZp bGU6Ol9maWxlTGFzdEVycm9yKCkgPT0gNTsgIyBhY2Nlc3MgaXMgZGVuaWVk CiAkb2sgb3IgcHJpbnQgIiMgIixmaWxlTGFzdEVycm9yKCksIlxuIjsKIHBy aW50ICRvayA/ICIiIDogIm5vdCAiLCAib2sgIiwgKyskdGVzdCwgIlxuIjsJ IyBvayAyMwogCiAkb2s9ICEgQ29weUZpbGUoICJSZWFkT25seS50eHQiLCAi Q2FuV3JpdGUudHh0IiwgMSApCi0gJiYgIGZpbGVMYXN0RXJyb3IoKSA9fiAv ZmlsZSBleGlzdHM/L2k7CisgJiYgIFdpbjMyQVBJOjpGaWxlOjpfZmlsZUxh c3RFcnJvcigpID09IDgwOyAjIGZpbGUgZXhpc3RzCiAkb2sgb3IgcHJpbnQg IiMgIixmaWxlTGFzdEVycm9yKCksIlxuIjsKIHByaW50ICRvayA/ICIiIDog Im5vdCAiLCAib2sgIiwgKyskdGVzdCwgIlxuIjsJIyBvayAyNAogCiAkb2s9 ICEgQ29weUZpbGUoICJDYW5Xcml0ZS50eHQiLCAiUmVhZE9ubHkudHh0Iiwg MCApCi0gJiYgIGZpbGVMYXN0RXJyb3IoKSA9fiAvYWNjZXNzIGlzIGRlbmll ZD8vaTsKKyAmJiAgV2luMzJBUEk6OkZpbGU6Ol9maWxlTGFzdEVycm9yKCkg PT0gNTsgIyBhY2Nlc3MgaXMgZGVuaWVkCiAkb2sgb3IgcHJpbnQgIiMgIixm aWxlTGFzdEVycm9yKCksIlxuIjsKIHByaW50ICRvayA/ICIiIDogIm5vdCAi LCAib2sgIiwgKyskdGVzdCwgIlxuIjsJIyBvayAyNQogCiAkb2s9ICEgTW92 ZUZpbGUoICJOb1N1Y2hGaWxlIiwgIk5vU3VjaERlc3QiICkKLSAmJiAgZmls ZUxhc3RFcnJvcigpID1+IC9ub3QgZmluZCB0aGUgZmlsZS9pOworICYmICBX aW4zMkFQSTo6RmlsZTo6X2ZpbGVMYXN0RXJyb3IoKSA9PSAyOyAjIG5vdCBm aW5kIHRoZSBmaWxlCiAkb2sgb3IgcHJpbnQgIiMgIixmaWxlTGFzdEVycm9y KCksIlxuIjsKIHByaW50ICRvayA/ICIiIDogIm5vdCAiLCAib2sgIiwgKysk dGVzdCwgIlxuIjsJIyBvayAyNgogCiAkb2s9ICEgTW92ZUZpbGVFeCggIk5v U3VjaEZpbGUiLCAiTm9TdWNoRGVzdCIsIDAgKQotICYmICBmaWxlTGFzdEVy cm9yKCkgPX4gL25vdCBmaW5kIHRoZSBmaWxlL2k7CisgJiYgIFdpbjMyQVBJ OjpGaWxlOjpfZmlsZUxhc3RFcnJvcigpID09IDI7ICMgbm90IGZpbmQgdGhl IGZpbGUKICRvayBvciBwcmludCAiIyAiLGZpbGVMYXN0RXJyb3IoKSwiXG4i OwogcHJpbnQgJG9rID8gIiIgOiAibm90ICIsICJvayAiLCArKyR0ZXN0LCAi XG4iOwkjIG9rIDI3CiAKICRvaz0gISBNb3ZlRmlsZSggIlJlYWRPbmx5LnR4 dCIsICJDYW5Xcml0ZS50eHQiICkKLSAmJiAgZmlsZUxhc3RFcnJvcigpID1+ IC9maWxlIGFscmVhZHkgZXhpc3RzPy9pOworICYmICBXaW4zMkFQSTo6Rmls ZTo6X2ZpbGVMYXN0RXJyb3IoKSA9PSAxODM7ICMgZmlsZSBhbHJlYWR5IGV4 aXN0cwogJG9rIG9yIHByaW50ICIjICIsZmlsZUxhc3RFcnJvcigpLCJcbiI7 CiBwcmludCAkb2sgPyAiIiA6ICJub3QgIiwgIm9rICIsICsrJHRlc3QsICJc biI7CSMgb2sgMjgKIAogJG9rPSAhIE1vdmVGaWxlRXgoICJSZWFkT25seS50 eHQiLCAiQ2FuV3JpdGUudHh0IiwgMCApCi0gJiYgIGZpbGVMYXN0RXJyb3Io KSA9fiAvZmlsZSBhbHJlYWR5IGV4aXN0cz8vaTsKKyAmJiAgV2luMzJBUEk6 OkZpbGU6Ol9maWxlTGFzdEVycm9yKCkgPT0gMTgzOyAjIGZpbGUgYWxyZWFk eSBleGlzdHMKICRvayBvciBwcmludCAiIyAiLGZpbGVMYXN0RXJyb3IoKSwi XG4iOwogcHJpbnQgJG9rID8gIiIgOiAibm90ICIsICJvayAiLCArKyR0ZXN0 LCAiXG4iOwkjIG9rIDI5CiAKQEAgLTIyNCw3ICsyMjQsNyBAQAogcHJpbnQg JG9rID8gIiIgOiAibm90ICIsICJvayAiLCArKyR0ZXN0LCAiXG4iOwkjIG9r IDMwCiAKICRvaz0gISBNb3ZlRmlsZUV4KCAiQ2FuV3JpdGUudHh0IiwgIlJl YWRPbmx5LmNwIiwgTU9WRUZJTEVfUkVQTEFDRV9FWElTVElORyApCi0gJiYg IGZpbGVMYXN0RXJyb3IoKSA9fiAvYWNjZXNzIGlzIGRlbmllZD98Y2Fubm90 IGNyZWF0ZS9pOworICYmICBXaW4zMkFQSTo6RmlsZTo6X2ZpbGVMYXN0RXJy b3IoKSA9PSA1OyAjIGFjY2VzcyBpcyBkZW5pZWQKICRvayBvciBwcmludCAi IyAiLGZpbGVMYXN0RXJyb3IoKSwiXG4iOwogcHJpbnQgJG9rID8gIiIgOiAi bm90ICIsICJvayAiLCArKyR0ZXN0LCAiXG4iOwkjIG9rIDMxCiAKQEAgLTI0 NCw3ICsyNDQsNyBAQAogcHJpbnQgJG9rID8gIiIgOiAibm90ICIsICJvayAi LCArKyR0ZXN0LCAiXG4iOwkjIG9rIDM0CiAKICRvaz0gISBEZWxldGVGaWxl KCAiTW92ZWQuY3AiICkKLSAmJiAgZmlsZUxhc3RFcnJvcigpID1+IC9hY2Nl c3MgaXMgZGVuaWVkPy9pOworICYmICBXaW4zMkFQSTo6RmlsZTo6X2ZpbGVM YXN0RXJyb3IoKSA9PSA1OyAjIGFjY2VzcyBpcyBkZW5pZWQKICRvayBvciBw cmludCAiIyAiLGZpbGVMYXN0RXJyb3IoKSwiXG4iOwogcHJpbnQgJG9rID8g IiIgOiAibm90ICIsICJvayAiLCArKyR0ZXN0LCAiXG4iOwkjIG9rIDM1CiAK ------------=_1182622507-1276-46 Content-Type: text/plain; charset=us-ascii -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/ ------------=_1182622507-1276-46--