X-Spam-Check-By: sourceware.org
Message-ID: <45E9AAD8.7D1A3AF3@dessent.net>
Date: Sat, 03 Mar 2007 09:05:28 -0800
From: Brian Dessent <brian AT dessent DOT net>
X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U)
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: missing definition of __STRING macro in standard cygwin headers
References: <000001c75d7b$f1a52100$05ffa8c0 AT Hydrogen> <45E9A86E DOT 7030803 AT byu DOT net>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Reply-To: cygwin AT cygwin DOT com
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

Eric Blake wrote:

> Then that's a bug in FAAC.  Using any identifier in the __ namespace is
> admitting that your code is relying on implementation details, and it
> deserves to break when ported to a different implementation.
> 
> That said, submit a patch, and it will probably be applied, since it won't
> violate any standards to provide such a define.

Not to mention the fact that it's incredibly silly to rely on libc
headers to define something as trivial as the stringify operator which
is a standard part of the C language.  Does it also require
__COMMENTBEGIN to be defined as /*?  __BRACEBEGIN as {?  Why not just
use #x in the code in the first place?

By the way, I don't see why you can't just build this package like:

./configure CPPFLAGS="-D__STRING=#x" ..rest of configure options..

There's no need to modify any source for something this trivial.

Brian

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/