X-Spam-Check-By: sourceware.org
Date: Wed, 10 Jan 2007 10:22:52 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: bug in syscalls.cc sync()
Message-ID: <20070110092252.GJ23638@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <45A40B96 DOT 9090903 AT highlandsun DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <45A40B96.9090903@highlandsun.com>
User-Agent: Mutt/1.4.2.2i
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Jan  9 13:39, Howard Chu wrote:
> I was just browsing the CVSweb repository looking at the sync()
> implementation and noticed this small typo. It's not worth the trouble
> for me to download the CVS repository just for this:
> 
> /* sync: SUSv3 */
> extern "C" void
> sync ()
> {
>  char vol[CYG_MAX_PATH];
> 
>  if (wincap.has_guid_volumes ()) /* Win2k and newer */
>    {
>      char a_drive[CYG_MAX_PATH] = {0};
>      char b_drive[CYG_MAX_PATH] = {0};
> 
>      if (is_floppy ("A:"))
>        GetVolumeNameForVolumeMountPointA ("A:\\", a_drive, CYG_MAX_PATH);
>      if (is_floppy ("B:"))
>        GetVolumeNameForVolumeMountPointA ("B:\\", a_drive, CYG_MAX_PATH);
> 
> Notice the last line there - "a_drive" should be "b_drive".

Ouch.  Thanks for the report, I applied a fix to CVS.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/