X-Spam-Check-By: sourceware.org
Date: Thu, 21 Dec 2006 11:00:41 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Error building cygwin DLL from CVS HEAD
Message-ID: <20061221100041.GG8345@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <4589A5D7 DOT 3000701 AT acm DOT org> <458A00EA DOT 9060304 AT byu DOT net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <458A00EA.9060304@byu.net>
User-Agent: Mutt/1.4.2.2i
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Dec 20 20:35, Eric Blake wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> According to David Rothenberger on 12/20/2006 2:06 PM:
> > I'm encountering an error while trying to build dumper.cc. This is with
> > the latest CVS HEAD.
> > 
> > In file included from /usr/src/cygwin/src/winsup/utils/dumper.cc:16:
> > /usr/src/cygwin/src/include/elf/external.h:248: error:
> > `ATTRIBUTE_PACKED' does not name a type
> 
> I'm currently building with this workaround patch, but yes, it would be
> nice to be fixed...

You could also just install ansidecl.h from your cvs checkout into
/usr/include.  It's a bit unfortunate that the Makefile allows to build
dumper.exe even if the bfd directory is not part of the source tree.
This adds an implicit dependency to the installed version of binutils to
the build.  On the bright side, this allows to build dumper.exe even if
the bfd directory is not present in the source tree.

I'm not quite sure if it makes sense to tweak the dumper.cc file to
define ATTRIBUTE_PACKED.  This will become useless as soon as a new
binutils version is released, while the same problem will happen with
other newly defined macros in bfd land as time goes by.

So, what I did was to turn around the include order so that ansidecl.h
is included before bfd.h.  This works around the problem of the order in
which system include files are handled by gcc.  This way you always get
the ansidecl.h from the source tree before any one bfd.h file is
included.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/