X-Spam-Check-By: sourceware.org
Date: Sun, 29 Oct 2006 23:33:39 -0500 (EST)
From: Igor Peshansky <pechtcha AT cs DOT nyu DOT edu>
Reply-To: cygwin AT cygwin DOT com
To: Julian Hall <jules AT meridiandigital DOT co DOT uk>
cc: cygwin AT cygwin DOT com
Subject: Re: Install failing and leaving unusable system
In-Reply-To: <45448BF3.6060507@meridiandigital.co.uk>
Message-ID: <Pine.GSO.4.63.0610292326420.22731@access1.cims.nyu.edu>
References: <45448BF3 DOT 6060507 AT meridiandigital DOT co DOT uk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Sun, 29 Oct 2006, Julian Hall wrote:

> I know this has been discussed here before, but it seems that it's
> something that happens to a lot of people, so it should probably be
> fixed.  It seems as though a fairly simple update to the setup program
> might be helpful to people who have the problem.  In script.cc, there
> are currently lines that read:
>
>  if (retval)
>    log(LOG_PLAIN) << "abnormal exit: exit code=" << retval << endLog;;
>
>  /* if file exists then delete it otherwise just ignore no file error */
>  io_stream::remove ("cygfile://" + scriptName + ".done");
>
>  io_stream::move ("cygfile://" + scriptName,
>                   "cygfile://" + scriptName + ".done");
>
> I'd suggest changing them so that the destination filename in the case
> of an abnormal exit is different (e.g. scriptName + ".failed").  A flag
> could then be set so that a dialog box is shown at the end, stating that
> errors occurred running the postinstall scripts, and directing users to
> a simple shell script that can be run after rebooting, which will run
> all the /etc/postinstall/*.failed scripts and move them to appropraite
> ".done" names.
>
> Does that sound like a sensible idea?

It does sound reasonable, but here are a couple of observations:

1) This was proposed before (see the discussion thread starting at
<http://cygwin.com/ml/cygwin-apps/2006-03/msg00062.html>).  One
alternative is to avoid renaming the failed scripts altogether, so that
they get re-run on next setup.

2) Even if this change gets applied to CVS HEAD, we still need a new setup
release to make sure this gets used.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_	    pechtcha AT cs DOT nyu DOT edu | igor AT watson DOT ibm DOT com
ZZZzz /,`.-'`'    -.  ;-;;,_		Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'		old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/