X-Spam-Check-By: sourceware.org
X-Spam-Abuse: Please report all spam/abuse matters to abuse AT bulldogdsl DOT com
Message-ID: <45448BF3.6060507@meridiandigital.co.uk>
Date: Sun, 29 Oct 2006 11:09:39 +0000
From: Julian Hall <jules AT meridiandigital DOT co DOT uk>
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Install failing and leaving unusable system
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

I know this has been discussed here before, but it seems that it's 
something that happens to a lot of people, so it should probably be 
fixed.  It seems as though a fairly simple update to the setup program 
might be helpful to people who have the problem.  In script.cc, there 
are currently lines that read:

  if (retval)
    log(LOG_PLAIN) << "abnormal exit: exit code=" << retval << endLog;;

  /* if file exists then delete it otherwise just ignore no file error */
  io_stream::remove ("cygfile://" + scriptName + ".done");

  io_stream::move ("cygfile://" + scriptName,
                   "cygfile://" + scriptName + ".done");

I'd suggest changing them so that the destination filename in the case 
of an abnormal exit is different (e.g. scriptName + ".failed").  A flag 
could then be set so that a dialog box is shown at the end, stating that 
errors occurred running the postinstall scripts, and directing users to 
a simple shell script that can be run after rebooting, which will run 
all the /etc/postinstall/*.failed scripts and move them to appropraite 
".done" names.

Does that sound like a sensible idea?

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/