X-Spam-Check-By: sourceware.org
Message-ID: <45402F74.9030405@users.sourceforge.net>
Date: Wed, 25 Oct 2006 22:45:56 -0500
From: "Yaakov S (Cygwin Ports)" <yselkowitz AT users DOT sourceforge DOT net>
User-Agent: Thunderbird 1.5.0.7 (Windows/20060909)
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: another cygport bug
References: <453D9BC6 DOT 6000206 AT byu DOT net> <453ECAF4 DOT 9040103 AT users DOT sourceforge DOT net>
In-Reply-To: <453ECAF4.9040103@users.sourceforge.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Yaakov S (Cygwin Ports) wrote:
> Eric Blake wrote:
>>> The check for config_h in cygautoreconf does not work when the
>>> line requests a template by a different name, as is the case with
>>> coreutils 6.4:
>>> 
>>> $ grep CONFIG_HEADERS coreutils-6.4/configure.ac 
>>> AC_CONFIG_HEADERS([lib/config.h:lib/config.hin])
> 
> Thanks for the patch; cygautoreconf() and gnome2_autoreconf() are now
>  fixed in CVS.

Thinking about this today, I realized that the fix is incorrect.  The
goal is to touch the input file (not the generated header), so we want
the *right* side of the colon, but then there's the other example in the
autoconf info page, which is:

AC_CONFIG_HEADERS([defines.h:defs.pre:defines.h.in:defs.post])

So to cover all the cases, we would have to revert the patch and do:

for d in . ${ac_subdirs}
do
  config_h="$(grep 'A[CM]_CONFIG_HEADERS*' ${d}/${configure_ac} | sed -e
's!A[CM]_CONFIG_HEADERS*(\[*\(.*\))!\1!g' -e 's!\]*!!g')"

  case "${config_h}" in
    *:*) config_h_in="$(echo ${config_h//:/ } | cut -d ' ' -f 2-)" ;;
    *) config_h_in="${config_h}.in" ;;
  esac

  for f in ${config_h_in}
  do
    touch ${d}/${f}
  done
done

Agreed?


Yaakov
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFQC9zpiWmPGlmQSMRAgoXAJ44m+alw2ZhkHjGQbUTMVM1o6840wCfUHPP
B1diRTFyyX39+uUWlF2+1TU=
=N+ZL
-----END PGP SIGNATURE-----

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/