X-Spam-Check-By: sourceware.org
Message-ID: <4508A29A.30308@cygwin.com>
Date: Wed, 13 Sep 2006 20:30:18 -0400
From: "Larry Hall (Cygwin)" <reply-to-list-only-lh AT cygwin DOT com>
Reply-To: cygwin AT cygwin DOT com
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.5) Gecko/20060727 Fedora/1.5.0.5-1.fc4.remi Thunderbird/1.5.0.5 Mnenhy/0.7.4.0
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: bash-3.1-7　BUG
References: <091320060438 DOT 11140 DOT 45078B490008FD8600002B8422007610640A050E040D0C079D0A AT comcast DOT net>  <20060913052510 DOT GB1256 AT trixie DOT casa DOT cgf DOT cx>  <loom DOT 20060913T160909-692 AT post DOT gmane DOT org> <ee9oa9$sj$1 AT sea DOT gmane DOT org>  <ee9q53$74g$1 AT sea DOT gmane DOT org> <loom DOT 20060913T234039-426 AT post DOT gmane DOT org>  <ee9vg0$qeb$1 AT sea DOT gmane DOT org> <45089854 DOT 8010705 AT scytek DOT de> <45089B13 DOT 7080105 AT acm DOT org>
In-Reply-To: <45089B13.7080105@acm.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

David Rothenberger wrote:
> On 9/13/2006 4:46 PM, Volker Quetschke wrote:
>> mwoehlke wrote:
>>> Eric Blake wrote:
>>>> mwoehlke <mwoehlke <at> tibco.com> writes:
>> (snip)
>>>> ... If the file starts life binary mode (ie. was on a binary
>>>> mount), skip the check for \r in the scan (under the assumption that
>>>> on a binary mount, \r is intentional and not a line ending to be
>>>> collapsed), and use lseeks. 
>>> Sounds good! That will satisfy my request to not silently work on files
>>> that should be broken. :-)
>>
>> I'm seeing the next "make doesn't work anymore with DOS ... feature" 
>> coming
>> up here, only that it is bash this time. (snip)
>>
>> ... It is definitely in the eye of the beholder if one calls shell
>> scripts that worked so far as broken just because they have /r/n line
>> endings.
> 
> I strongly agree with this. The users I support would be much happier if 
> bash could continue to work correctly with \r\n in scripts on binary 
> mounts.
> 
> It sounds like bash will have to scan the first line regardless of the 
> mount type (to check for a binary file), so perhaps the decision to 
> treat \r as intentional or not could be an option?
> 

I think this is getting a little off-track.  Another option just means another
area for people who don't understand what's going on to trip and fall and then
come and bug the list as a result.  IMO, there's already such an option, even
without changing bash.  It's called 'd2u'.  Let's not over-think and over-do
things here.  There's pain involved in that too.  I'm not convinced that it's
worth the pain to all for the benefit of a few.  Of course, I firmly believe
that what can and will be done here is Eric's call.  He's the one that will be
maintaining it.

-- 
Larry Hall                              http://www.rfk.com
RFK Partners, Inc.                      (508) 893-9779 - RFK Office
216 Dalton Rd.                          (508) 893-9889 - FAX
Holliston, MA 01746

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/