X-Spam-Check-By: sourceware.org Date: Wed, 13 Sep 2006 20:19:02 -0400 From: Christopher Faylor To: cygwin AT cygwin DOT com Subject: Re: bash-3.1-7 BUG Message-ID: <20060914001902.GB24899@trixie.casa.cgf.cx> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com References: <091320060438 DOT 11140 DOT 45078B490008FD8600002B8422007610640A050E040D0C079D0A AT comcast DOT net> <20060913052510 DOT GB1256 AT trixie DOT casa DOT cgf DOT cx> <45089854 DOT 8010705 AT scytek DOT de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45089854.8010705@scytek.de> User-Agent: Mutt/1.5.11 Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com On Wed, Sep 13, 2006 at 04:46:28PM -0700, Volker Quetschke wrote: >mwoehlke wrote: >>Eric Blake wrote: >>>mwoehlke tibco.com> writes: >(snip) >>>... If the scan in binary mode succeeds, then leave the file in binary >>>mode, assuming that the file is unix format even though it is on a text >>>mount, and that lseeks will work. If the file starts life binary mode >>>(ie. was on a binary mount), skip the check for \r in the scan (under >>>the assumption that on a binary mount, \r is intentional and not a line >>>ending to be collapsed), and use lseeks. No guarantees on whether this >>>will pan out, or be bigger than I thought, but hopefully you will see a >>>bash 3.1-8 with these semantics soon. >> >>Sounds good! That will satisfy my request to not silently work on files >>that should be broken. :-) > >I'm seeing the next "make doesn't work anymore with DOS ... feature" >coming up here, only that it is bash this time. Apparently a lot of >people use tools from cygwin to build Windows stuff in a *NIX build >environment. Do I have to make the observation again that whether this is the case or not, it is not a primary goal of the Cygwin project to support these people? As long as you have Corinna or myself in charge we are going to stick with the whole "Linux on Windows" thing. If bash doesn't like \r\n line endings on Linux, if we purposely recommend against using text mode files, and if we can see noticeable performance improvements in bash from not honoring \r\n line endings, then bash should definitely be using the "binmode" code. If Eric cares enough to make \r\n shell scripts work in bash, then more power to him. If he doesn't then I have no problem with releasing a bash that hiccups on files which use \r\n and informing people that they should fix their scripts. cgf -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/