X-Spam-Check-By: sourceware.org
Date: Wed, 13 Sep 2006 16:58:11 -0700
From: David Rothenberger <daveroth AT acm DOT org>
Subject: Re: bash-3.1-7　BUG
In-reply-to: <45089854.8010705@scytek.de>
To: cygwin AT cygwin DOT com
Message-id: <45089B13.7080105@acm.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
References:  <091320060438 DOT 11140 DOT 45078B490008FD8600002B8422007610640A050E040D0C079D0A AT comcast DOT net>  <20060913052510 DOT GB1256 AT trixie DOT casa DOT cgf DOT cx>  <loom DOT 20060913T160909-692 AT post DOT gmane DOT org> <ee9oa9$sj$1 AT sea DOT gmane DOT org>  <ee9q53$74g$1 AT sea DOT gmane DOT org> <loom DOT 20060913T234039-426 AT post DOT gmane DOT org>  <ee9vg0$qeb$1 AT sea DOT gmane DOT org> <45089854 DOT 8010705 AT scytek DOT de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.5)  Gecko/20060719 Thunderbird/1.5.0.5 Mnenhy/0.7.4.666
X-IsSubscribed: yes
Reply-To: cygwin AT cygwin DOT com
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On 9/13/2006 4:46 PM, Volker Quetschke wrote:
> mwoehlke wrote:
>> Eric Blake wrote:
>>> mwoehlke <mwoehlke <at> tibco.com> writes:
> (snip)
>>> ... If the file starts life binary mode (ie. was on a binary
>>> mount), skip the check for \r in the scan (under the assumption that
>>> on a binary mount, \r is intentional and not a line ending to be
>>> collapsed), and use lseeks. 
>> Sounds good! That will satisfy my request to not silently work on files
>> that should be broken. :-)
> 
> I'm seeing the next "make doesn't work anymore with DOS ... feature" coming
> up here, only that it is bash this time. (snip)
> 
> ... It is definitely in the eye of the beholder if one calls shell
> scripts that worked so far as broken just because they have /r/n line
> endings.

I strongly agree with this. The users I support would be much happier if 
bash could continue to work correctly with \r\n in scripts on binary 
mounts.

It sounds like bash will have to scan the first line regardless of the 
mount type (to check for a binary file), so perhaps the decision to 
treat \r as intentional or not could be an option?

-- 
David Rothenberger                spammer? -> spam AT daveroth DOT dyndns DOT org
GPG/PGP: 0x92D68FD8, DB7C 5146 1AB0 483A 9D27 DFBA FBB9 E328 92D6 8FD8

   If Roosevelt were alive, he'd turn over in his grave. -Samuel
   Goldwyn


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/