X-Spam-Check-By: sourceware.org
Date: Wed, 19 Jul 2006 11:02:09 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: msync failure due to rounding up length (with test case and suggested fix)
Message-ID: <20060719090209.GA18664@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <ee2a432c0607182036o7a0b12f8jea6e2d28fea50c48 AT mail DOT gmail DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ee2a432c0607182036o7a0b12f8jea6e2d28fea50c48@mail.gmail.com>
User-Agent: Mutt/1.4.2i
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Jul 18 20:36, Neal Norwitz wrote:
> See winsup/cygwin/mmap.cc line 1355 in current CVS (msync function):
> 
>  len = roundup2 (len, pagesize);
> 
> I verified my suspicion that roundup2() is causing Python's test suite
> to fail.

Thanks for the testcase.  I agree that rounding up len is wrong.
Unfortunately I have no recollection why I added this and I missed to
add a comment apparently <mental note>add more comments</mental note>.
I removed it now.


Thanks again for the testcase,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/