X-Spam-Check-By: sourceware.org
Date: Wed, 26 Apr 2006 12:09:03 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: [Patch] patch -Z not working if timestamp contains seconds >=59.5
Message-ID: <20060426100903.GR28583@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <054c01c668a4$554924e0$a501a8c0 AT CAM DOT ARTIMI DOT COM> <444E95C0 DOT 9080708 AT t-online DOT de> <20060426080858 DOT GA14738 AT sellafield DOT lysator DOT liu DOT se> <1FYg6G-0BFM1o0 AT fwd31 DOT aul DOT t-online DOT de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1FYg6G-0BFM1o0@fwd31.aul.t-online.de>
User-Agent: Mutt/1.4.2i
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Apr 26 11:14, Christian Franke wrote:
> Peter Ekberg wrote:
> 
> > If you thought about all that, maybe you also thought about leap
> seconds?
> > Isn't it valid to have 60 in the seconds field when a leap second is
> added?
> 
> Yes, this should be valid.
> But maketime() does not provide portable support for it, because it
> relies on gmtime/localtime of the platform's libc.
> On Cygwin, maketime() does not accept 2005-12-31 23:59:60 UTC as a valid
> time.

I don't see what this has to do with gmtime/localtime since both
functions create a struct tm from a time_t, not the other way around.

I just tested your testcase with patch-2.5.9 on Linux and the same
effect happens, so it's apparently not a Cygwin specific problem.

Would you mind to discuss this on bug-patch AT gnu DOT org?  As far
as my opinion counts, I'd think that aligning its behaviour with tar
would be a good thing.  But the core developers might have an entirely
different opinion...


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/