X-Spam-Check-By: sourceware.org
Date: Tue, 7 Feb 2006 16:19:25 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: file listing incorrect in cvs head.
Message-ID: <20060207151925.GH2979@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <20060207 DOT 225517 DOT 193759270 DOT hashiz AT tomba DOT cskk-sv DOT co DOT jp> <20060207140729 DOT GF2979 AT calimero DOT vinschen DOT de> <20060208 DOT 000622 DOT 226728532 DOT hashiz AT tomba DOT cskk-sv DOT co DOT jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060208.000622.226728532.hashiz@tomba.cskk-sv.co.jp>
User-Agent: Mutt/1.4.2i
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Feb  8 00:06, HASHI Hiroaki wrote:
> > Thanks, but the patch isn't exactly "trivial", so we would need a 
> > copyright assignment from you and, possibly, from your employer.
> > See http://cygwin.com/contrib.html.
> 
> Oh.
> 
> I regard my employer as not agreeing.
> 
> I hope, anyone re-write a patch and appling it.

I'm going to change that, no worries.

> > Why isn't it sufficient just to replace wcstombs by a call to sys_wcstombs?
> > The filename can't be longer than 255 wide chars so the result won't be
> > longer than 255 chars, right?
> 
> I am given to worrying.
> 
>   - 'FileName' teminated by NULL, really?

No, you're right, FileName is not 0-terminated on return from
NtQueryDirectoryFile.  I inspected our sys_wcstombs implementation again
and it makes at least two invalid assumptions.  I'm going to rework our
sys_wcstombs function.  You should see the fix in the next snapshot.


Thanks for the hint,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/