X-Spam-Check-By: sourceware.org
Message-ID: <7ff9c2a10601301105n541574b1r73c33df74d5df98d@mail.gmail.com>
Date: Mon, 30 Jan 2006 11:05:49 -0800
From: Svend Sorensen <ssorensen AT gmail DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: 1.5.19: pdksh 5.2.14-3 tab-complete and shell metacharacters
In-Reply-To: <Pine.GSO.4.63.0601301220010.2628@access1.cims.nyu.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Disposition: inline
References: <7ff9c2a10601261111m49ab467enfa427a546e269132 AT mail DOT gmail DOT com> 	 <Pine DOT GSO DOT 4 DOT 63 DOT 0601300835190 DOT 7389 AT access1 DOT cims DOT nyu DOT edu> 	 <7ff9c2a10601300918h7a456f83s4b2f7e4d2416e393 AT mail DOT gmail DOT com> 	 <Pine DOT GSO DOT 4 DOT 63 DOT 0601301220010 DOT 2628 AT access1 DOT cims DOT nyu DOT edu>
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id k0UJ61PI015819

On 1/30/06, Igor Peshansky <pechtcha AT cs DOT nyu DOT edu> wrote:
> Ugh, top-posting...  Reformatted.
>
> On Mon, 30 Jan 2006, Svend Sorensen wrote:
>
> > On 1/30/06, Igor Peshansky <pechtcha AT XX DOT XXX DOT XXX> wrote:
>
> <http://cygwin.com/acronyms/#PCYMTNQREAIYR>.  Thanks.
>
> > > On Thu, 26 Jan 2006, Svend Sorensen wrote:
> > >
> > > > When I use pdksh to expand the name of a file with spaces or other
> > > > shell metachars in it, the filename is expanded without escaping the
> > > > metacharacters.
> > >
> > > Thanks for the report.  I've been able to reproduce this.  There's an
> > > upstream patch that fixes the issue, and I'm currently working on
> > > integrating that and other patches into the build to produce a new
> > > release (but no ETA yet).
> > >
> > > > The pdksh version strings are identical.
> > >
> > > This is unfortunate.  What is the patchlevel shown for the pdksh
> > > package on NetBSD?
> > >
> > > FWIW, I will include the full list of patches in the README for the
> > > new release.
> >
> > The NetBSD system I tested has pdksh-5.2.14nb1 installed.  There are
> > two patches in pkgsrc, one which removes a Makefile check for pdksh in
> > the /etc/shells file, and one which removes a declaration of errorno.
> > Other than that, it uses the vanilla pdksh-5.2.14.tar.gz sources.
>
> Hmm, this is extremely surprising, as 5.2.14 doesn't contain any code to
> quote shell metacharacters on tab completion.  Are you sure those are
> vanilla sources?  I know OpenBSD uses its own CVS repository for PDKSH --
> does NetBSD do this too?  Can you compare the tarball with
> <ftp://ftp.cs.mun.ca/pub/pdksh/pdksh-5.2.14.tar.gz>?

It turns out I was running NetBSD's base ksh, which must be a patched pdksh.

I tested the version of pdksh in pkgsrc, and it has no metacharacter
expansion.  The pkgsrc version of pdksh uses that source tarball you
mentioned.

> > I have attached the patches from pkgsrc.
>
> These patches don't seem to do anything interesting.
>
> The next release of PDKSH on Cygwin will be built with a metacharacter
> quoting patch (from Debian).  I'd still like to investigate this to see
> why it works for you on NetBSD without that patch...

NetBSD must patch their stock pdksh, which would make this a feature
request, not a bug report.

Should NetBSD modify their base KSH_VERSION reporting to show it is patched?

Thanks for your help, Igor.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/