X-Spam-Check-By: sourceware.org
Date: Mon, 30 Jan 2006 12:25:47 -0500 (EST)
From: Igor Peshansky <pechtcha AT cs DOT nyu DOT edu>
Reply-To: cygwin AT cygwin DOT com
To: Svend Sorensen <ssorensen AT gmail DOT com>
cc: cygwin AT cygwin DOT com
Subject: Re: 1.5.19: pdksh 5.2.14-3 tab-complete and shell metacharacters
In-Reply-To: <7ff9c2a10601300918h7a456f83s4b2f7e4d2416e393@mail.gmail.com>
Message-ID: <Pine.GSO.4.63.0601301220010.2628@access1.cims.nyu.edu>
References: <7ff9c2a10601261111m49ab467enfa427a546e269132 AT mail DOT gmail DOT com>    <Pine DOT GSO DOT 4 DOT 63 DOT 0601300835190 DOT 7389 AT access1 DOT cims DOT nyu DOT edu>  <7ff9c2a10601300918h7a456f83s4b2f7e4d2416e393 AT mail DOT gmail DOT com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

Ugh, top-posting...  Reformatted.

On Mon, 30 Jan 2006, Svend Sorensen wrote:

> On 1/30/06, Igor Peshansky <pechtcha AT XX DOT XXX DOT XXX> wrote:

<http://cygwin.com/acronyms/#PCYMTNQREAIYR>.  Thanks.

> > On Thu, 26 Jan 2006, Svend Sorensen wrote:
> >
> > > When I use pdksh to expand the name of a file with spaces or other
> > > shell metachars in it, the filename is expanded without escaping the
> > > metacharacters.
> >
> > Thanks for the report.  I've been able to reproduce this.  There's an
> > upstream patch that fixes the issue, and I'm currently working on
> > integrating that and other patches into the build to produce a new
> > release (but no ETA yet).
> >
> > > The pdksh version strings are identical.
> >
> > This is unfortunate.  What is the patchlevel shown for the pdksh
> > package on NetBSD?
> >
> > FWIW, I will include the full list of patches in the README for the
> > new release.
>
> The NetBSD system I tested has pdksh-5.2.14nb1 installed.  There are
> two patches in pkgsrc, one which removes a Makefile check for pdksh in
> the /etc/shells file, and one which removes a declaration of errorno.
> Other than that, it uses the vanilla pdksh-5.2.14.tar.gz sources.

Hmm, this is extremely surprising, as 5.2.14 doesn't contain any code to
quote shell metacharacters on tab completion.  Are you sure those are
vanilla sources?  I know OpenBSD uses its own CVS repository for PDKSH --
does NetBSD do this too?  Can you compare the tarball with
<ftp://ftp.cs.mun.ca/pub/pdksh/pdksh-5.2.14.tar.gz>?

> I have attached the patches from pkgsrc.

These patches don't seem to do anything interesting.

The next release of PDKSH on Cygwin will be built with a metacharacter
quoting patch (from Debian).  I'd still like to investigate this to see
why it works for you on NetBSD without that patch...
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_	    pechtcha AT cs DOT nyu DOT edu | igor AT watson DOT ibm DOT com
ZZZzz /,`.-'`'    -.  ;-;;,_		Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'		old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/