X-Spam-Check-By: sourceware.org
Message-ID: <43D6B6D8.B0CBB42B@dessent.net>
Date: Tue, 24 Jan 2006 15:23:04 -0800
From: Brian Dessent <brian AT dessent DOT net>
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: Errors compiling cdrtools under cygwin 1.5.19
References: <012420061825 DOT 2204 DOT 43D671090006A0AD0000089C22092299270A050E040D0C079D0A AT comcast DOT net> <20060124183552 DOT GA2889 AT trixie DOT casa DOT cgf DOT cx> <43D69F82 DOT 8050209 AT verysmall DOT org>
Content-Type: multipart/mixed;  boundary="------------41FDC05097EF040D841BA3C0"
X-IsSubscribed: yes
Reply-To: cygwin AT cygwin DOT com
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

--------------41FDC05097EF040D841BA3C0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

"pobox AT verysmall DOT org" wrote:

> I do not want to heat the discussion, but getline() in cygwin played
> very hard against me.

Like I said in the other thread, you can fix this in Apache (and
cdrtools for that matter -- see attached patch) with a couple of
#defines in the offending files.  It's really simple.

If you can't deal with simple patches then why are you building from
source?  In open source projects it's often the case that if you're
building things yourself there will sometimes have to actually get your
hands dirty and modify the source.  To expect every open source package
to compile on every platform out-of-the-box every time is absurd. 
That's why most people use binary packages, and most distributors of
binary packages have metric craploads of patches -- most just trivial
build fixes like this.

Brian
--------------41FDC05097EF040D841BA3C0
Content-Type: text/plain; charset=us-ascii;
 name="cdrtools_getline.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cdrtools_getline.patch"

diff -upr cdrtools-2.01/cdrecord/cue.c /usr/src/cdrtools-2.01/cdrecord/cue.c
--- cdrtools-2.01/cdrecord/cue.c	2004-03-02 12:00:53.000000000 -0800
+++ /usr/src/cdrtools-2.01/cdrecord/cue.c	2005-12-17 16:22:53.796875000 -0800
@@ -44,6 +44,8 @@ static	char sccsid[] =
 #include "auheader.h"
 #include "libport.h"
 
+#define getdelim schily_getdelim
+
 typedef struct state {
 	char	*filename;
 	void	*xfp;
diff -upr cdrtools-2.01/include/schily.h /usr/src/cdrtools-2.01/include/schily.h
--- cdrtools-2.01/include/schily.h	2004-03-04 16:30:40.000000000 -0800
+++ /usr/src/cdrtools-2.01/include/schily.h	2005-12-17 16:19:09.015625000 -0800
@@ -39,6 +39,8 @@
 #ifndef _SCHILY_H
 #define	_SCHILY_H
 
+#define getline schily_getline
+
 #ifndef _STANDARD_H
 #include <standard.h>
 #endif


--------------41FDC05097EF040D841BA3C0
Content-Type: text/plain; charset=us-ascii

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/
--------------41FDC05097EF040D841BA3C0--